Differential D41691

tcp: Initialize maximum number of entries in a client cookie cache bucket
ClosedPublic
Actions

Authored by zlei on Sep 2 2023, 6:36 AM.

Tags

None

Referenced Files

	F146787503: D41691.diff
	Thu, Mar 5, 2:41 PM

	Unknown Object (File)
	Wed, Mar 4, 1:44 PM

	Unknown Object (File)
	Wed, Feb 18, 1:37 PM

	Unknown Object (File)
	Wed, Feb 18, 1:37 PM

	Unknown Object (File)
	Wed, Feb 18, 1:37 PM

	Unknown Object (File)
	Tue, Feb 17, 11:01 AM

	Unknown Object (File)
	Tue, Feb 17, 11:01 AM

	Unknown Object (File)
	Tue, Feb 17, 11:00 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGaadedc5b3e4b: tcp: Initialize the maximum number of entries in a client cookie cache bucket
rG3fc299d68897: tcp: Initialize the maximum number of entries in a client cookie cache bucket
rG144851777eda: tcp: Initialize the maximum number of entries in a client cookie cache bucket
rG224aec05e732: tcp: Initialize the maximum number of entries in a client cookie cache bucket

Summary

This vnet loader tunable is defined with SYSCTL_PROC, thus will not
initialized by kernel on vnet creating and will always be the default
value TCP_FASTOPEN_CCACHE_BUCKET_LIMIT_DEFAULT.

PR: 273509
Fixes: c560df6f12f1 This is an implementation of the client side of TCP Fast Open (TFO) [RFC7413]
MFC after: 3 days

Test Plan

# sysctl net.inet.tcp.fastopen.ccache_bucket_limit
16
# echo "net.inet.tcp.fastopen.ccache_bucket_limit=32" >> /boot/loader.conf
# reboot
....
# sysctl net.inet.tcp.fastopen.ccache_bucket_limit
32

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Sep 2 2023, 6:36 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSep 2 2023, 6:36 AM

zlei requested review of this revision.Sep 2 2023, 6:36 AM

zlei edited the summary of this revision. (Show Details)Sep 2 2023, 6:40 AM

zlei mentioned this in D41525: Mark vnet loader tunnables with CTLFLAG_NOFETCH.Sep 2 2023, 6:46 AM

tuexen accepted this revision.Sep 2 2023, 7:54 AM

This revision is now accepted and ready to land.Sep 2 2023, 7:54 AM

Closed by commit rG224aec05e732: tcp: Initialize the maximum number of entries in a client cookie cache bucket (authored by zlei). · Explain WhySep 2 2023, 8:36 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG224aec05e732: tcp: Initialize the maximum number of entries in a client cookie cache bucket.

zlei added a commit: rG144851777eda: tcp: Initialize the maximum number of entries in a client cookie cache bucket.Sep 6 2023, 4:09 AM

zlei added a commit: rG3fc299d68897: tcp: Initialize the maximum number of entries in a client cookie cache bucket.Sep 6 2023, 4:20 AM

zlei added a commit: rGaadedc5b3e4b: tcp: Initialize the maximum number of entries in a client cookie cache bucket.Sep 6 2023, 4:53 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

5 lines

Diff 126819

sys/netinet/tcp_fastopen.c

Loading...