Page MenuHomeFreeBSD

armv8_crypto: fix recursive fpu_kern_enter call
ClosedPublic

Authored by zachary.leaf_arm.com on Aug 31 2023, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 5, 6:34 AM
Unknown Object (File)
Fri, Oct 3, 2:22 AM
Unknown Object (File)
Wed, Oct 1, 12:16 AM
Unknown Object (File)
Tue, Sep 30, 2:42 AM
Unknown Object (File)
Mon, Sep 29, 1:21 AM
Unknown Object (File)
Aug 31 2025, 2:43 AM
Unknown Object (File)
Aug 6 2025, 4:31 PM
Unknown Object (File)
Aug 5 2025, 7:13 PM
Subscribers

Details

Summary

Now armv8_crypto is using FPU_KERN_NOCTX, this results in a kernel panic
in armv8_crypto.c:armv8_crypto_cipher_setup:

panic: recursive fpu_kern_enter while in PCB_FP_NOSAVE state

This is because in armv8_crypto.c:armv8_crypto_cipher_process,
directly after calling fpu_kern_enter() a call is made to
armv8_crypto_cipher_setup(), resulting in nested calls to
fpu_kern_enter() without the required fpu_kern_leave() inbetween.

Move fpu_kern_enter() in armv8_crypto_cipher_process() after the
call to armv8_crypto_cipher_setup() to resolve this.

Fixes: 6485286f536f ("armv8_crypto: Switch to using FPU_KERN_NOCTX")
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable