Page MenuHomeFreeBSD

armv8_crypto: fix recursive fpu_kern_enter call
ClosedPublic

Authored by zachary.leaf_arm.com on Aug 31 2023, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 3:33 PM
Unknown Object (File)
Wed, Nov 26, 1:34 AM
Unknown Object (File)
Mon, Nov 24, 3:03 AM
Unknown Object (File)
Sun, Nov 23, 4:44 AM
Unknown Object (File)
Wed, Nov 19, 5:10 AM
Unknown Object (File)
Sun, Nov 16, 11:25 AM
Unknown Object (File)
Mon, Nov 10, 4:16 PM
Unknown Object (File)
Fri, Nov 7, 3:30 AM
Subscribers

Details

Summary

Now armv8_crypto is using FPU_KERN_NOCTX, this results in a kernel panic
in armv8_crypto.c:armv8_crypto_cipher_setup:

panic: recursive fpu_kern_enter while in PCB_FP_NOSAVE state

This is because in armv8_crypto.c:armv8_crypto_cipher_process,
directly after calling fpu_kern_enter() a call is made to
armv8_crypto_cipher_setup(), resulting in nested calls to
fpu_kern_enter() without the required fpu_kern_leave() inbetween.

Move fpu_kern_enter() in armv8_crypto_cipher_process() after the
call to armv8_crypto_cipher_setup() to resolve this.

Fixes: 6485286f536f ("armv8_crypto: Switch to using FPU_KERN_NOCTX")
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable