qat: Intel® 4xxx Series driver API extention
ClosedPublic
Actions

Authored by piotrx.kasierski_intel.com on Aug 28 2023, 9:47 AM.

Details

Reviewers

Commits

rGffaa91929f2d: qat: Intel 4xxx Series driver API extension
rGc265e6217951: qat: Intel 4xxx Series driver API extension
rG22cf89c93888: qat: Intel 4xxx Series driver API extension

Summary

Overview:
Intel(R) QuickAssist Technology (Intel(R) QAT) provides hardware
acceleration for offloading security, authentication and compression
services from the CPU, thus significantly increasing the performance and
efficiency of standard platform solutions.

This commit introduces:

Quick Assist API update for partial decompress and zero padding.
Refactor of UIO locking.
VF driver hotplug fix.
Minor code style fixes for firmware API.

Patch co-authored by: Krzysztof Zdziarski <krzysztofx.zdziarski@intel.com>
Patch co-authored by: Michal Gulbicki <michalx.gulbicki@intel.com>
Patch co-authored by: Piotr Kasierski <piotrx.kasierski@intel.com>
Patch co-authored by: Karol Grzadziel <karolx.grzadziel@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

piotrx.kasierski_intel.com created this revision.Aug 28 2023, 9:47 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 28 2023, 9:47 AM

piotrx.kasierski_intel.com requested review of this revision.Aug 28 2023, 9:47 AM

Harbormaster completed remote builds in B53313: Diff 126576.Aug 28 2023, 9:47 AM

piotrx.kasierski_intel.com added a reviewer: markj.Aug 28 2023, 9:51 AM

MichalX.Gulbicki_intel.com added a subscriber: MichalX.Gulbicki_intel.com.Aug 28 2023, 9:56 AM

piotrx.kasierski_intel.com awarded a token.Aug 28 2023, 9:56 AM

piotrx.kasierski_intel.com added a subscriber: krzysztofx.zdziarski_intel.com.

qat: Intel® 4xxx Series driver API extention

Summary:
Overview:
Intel(R) QuickAssist Technology (Intel(R) QAT) provides hardware
acceleration for offloading security, authentication and compression
services from the CPU, thus significantly increasing the performance and
efficiency of standard platform solutions.

This commit introduces:
- Quick Assist API update for partial decompress and zero padding.
- UIO support locking simplification.
- Fixed VF driver hotplug.

Patch co-authored by: Krzysztof Zdziarski <krzysztofx.zdziarski@intel.com>
Patch co-authored by: Michal Gulbicki <michalx.gulbicki@intel.com>
Patch co-authored by: Piotr Kasierski <piotrx.kasierski@intel.com>
Patch co-authored by: Karol Grzadziel <karolx.grzadziel@intel.com>

Sponsored by: Intel Corporation

Subscribers: imp

Differential Revision: https://reviews.freebsd.org/D41613

Harbormaster completed remote builds in B53315: Diff 126578.Aug 28 2023, 10:31 AM

piotrx.kasierski_intel.com edited the summary of this revision. (Show Details)Aug 28 2023, 10:31 AM

Seems ok to me. The commit log message is quite vague - is there some reference documentation explaining the changes that we can link to?

There are also quite a few code/comment style changes, but this is not mentioned in the commit log.

This revision is now accepted and ready to land.Aug 28 2023, 1:55 PM

piotrx.kasierski_intel.com updated this revision to Diff 126625.Aug 29 2023, 8:21 AM

This comment was removed by piotrx.kasierski_intel.com.

This revision now requires review to proceed.Aug 29 2023, 8:21 AM

Harbormaster completed remote builds in B53326: Diff 126625.Aug 29 2023, 8:21 AM

piotrx.kasierski_intel.com edited the summary of this revision. (Show Details)Aug 29 2023, 8:22 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2023, 2:01 PM

Closed by commit rG22cf89c93888: qat: Intel 4xxx Series driver API extension (authored by piotrx.kasierski_intel.com, committed by markj). · Explain Why