Paths

Table of Contentst

hwpmc: on process exit, ensure that the owned log is closed
ClosedPublic
Actions

Authored by kib on Aug 21 2023, 10:36 AM.

Tags

None

Referenced Files

	F153478533: D41521.diff
	Tue, Apr 21, 9:38 AM

	F153459636: D41521.id126289.diff
	Tue, Apr 21, 7:20 AM

	Unknown Object (File)
	Mon, Apr 20, 9:36 PM

	Unknown Object (File)
	Mon, Apr 20, 1:01 PM

	Unknown Object (File)
	Sun, Apr 19, 8:17 PM

	Unknown Object (File)
	Sat, Apr 18, 1:35 PM

	Unknown Object (File)
	Wed, Apr 8, 11:34 PM

	Unknown Object (File)
	Wed, Apr 8, 11:30 PM

View All Files

Subscribers

imp

pho

Details

Reviewers

jrtc27
markj
gnn

Commits

rG3c872a70b883: hwpmc: on process exit, ensure that the owned log is closed

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 21 2023, 10:36 AM

Herald added a reviewer: gnn. · View Herald TranscriptAug 21 2023, 10:36 AM

Herald added a subscriber: imp. · View Herald Transcript

kib requested review of this revision.Aug 21 2023, 10:36 AM

markj added inline comments.Aug 21 2023, 12:35 PM

sys/dev/hwpmc/hwpmc_mod.c
5119	Doesn't this need to be conditional on `(po->po_flags & PMC_PO_OWNS_LOGFILE) != 0`?

Check PMC_PO_OWNS_LOGFILE

markj accepted this revision.Aug 21 2023, 1:23 PM

This revision is now accepted and ready to land.Aug 21 2023, 1:23 PM

Closed by commit rG3c872a70b883: hwpmc: on process exit, ensure that the owned log is closed (authored by kib). · Explain WhyAug 21 2023, 1:34 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3c872a70b883: hwpmc: on process exit, ensure that the owned log is closed.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

8 lines

Diff 126303

View Options

hwpmc: on process exit, ensure that the owned log is closedClosedPublicActions