Page MenuHomeFreeBSD

libc: regoranize malloc build
ClosedPublic

Authored by brooks on Aug 14 2023, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 7:12 AM
Unknown Object (File)
Mon, May 6, 9:35 AM
Unknown Object (File)
Fri, May 3, 3:56 PM
Unknown Object (File)
Wed, May 1, 11:33 PM
Unknown Object (File)
Wed, May 1, 11:32 PM
Unknown Object (File)
Wed, May 1, 11:31 PM
Unknown Object (File)
Wed, May 1, 11:30 PM
Unknown Object (File)
Wed, May 1, 11:30 PM
Subscribers
None

Details

Summary

Create a stdlib/malloc to hold the definition of the malloc interface
(e.g., the Symbol.map file) and make jemalloc a subdirectory. This will
make it easier to integrate alternative allocators such as snmalloc
while making it clear that the current jemalloc symbols are the FreeBSD
API/ABI (for better or worse).

Suggested by: jrtc27

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

Use LIBC_SRCTOP relative paths

lib/libc/stdlib/malloc/Makefile.inc
2
lib/libc/stdlib/malloc/jemalloc/Makefile.inc
0–1

I guess this should change? Or just go away given there are no sources here...

brooks marked 2 inline comments as done.
  • Fix SYM_MAPS
  • Remove unused .PATH
lib/libc/stdlib/malloc/Makefile.inc
2

Sigh, CI caught this, but I updated too soon. Fixed now.

This revision is now accepted and ready to land.Aug 15 2023, 11:47 PM

Though please note the .PATH GC'ing in the commit message

Though please note the .PATH GC'ing in the commit message

Split out into D41481

This revision now requires review to proceed.Aug 16 2023, 3:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2023, 6:20 PM
This revision was automatically updated to reflect the committed changes.