Differential D41446

netstat(1): teach netstat to attach to jails
ClosedPublic
Actions

Authored by dfr on Aug 14 2023, 9:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 7:46 AM

	Unknown Object (File)
	Sat, Apr 27, 7:45 AM

	Unknown Object (File)
	Sat, Apr 27, 6:08 AM

	Unknown Object (File)
	Mar 12 2024, 6:09 PM

	Unknown Object (File)
	Mar 12 2024, 6:09 PM

	Unknown Object (File)
	Mar 12 2024, 2:47 PM

	Unknown Object (File)
	Dec 23 2023, 10:31 AM

	Unknown Object (File)
	Dec 13 2023, 3:37 AM

View All 11 Files

Subscribers

freebsd_igalic.co

Details

Reviewers: None
Commits: rG153a0e6b038c: netstat(1): teach netstat to attach to jails
rG182e8ae26d7c: netstat(1): teach netstat to attach to jails

Summary

Add -j <jail> flag to netstat(1) to allow access to network information
from a jail.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dfr created this revision.Aug 14 2023, 9:17 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2023, 9:17 AM

dfr requested review of this revision.Aug 14 2023, 9:17 AM

Harbormaster completed remote builds in B53089: Diff 125960.Aug 14 2023, 9:17 AM

lwhsu added a subscriber: lwhsu.Aug 14 2023, 9:20 PM

The code change here is fairly straightforward and brings netstat in line with similar support in ifconfig and route. The manpage change is larger and it would be nice to get a review if possible. I know people are busy this week preparing for the stable/14 branch - I'll leave the review up for another day. If someone has time to give it a review then great, otherwise I'll commit anyway and we can fix any manpage issues as followups.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2023, 1:06 PM

Closed by commit rG182e8ae26d7c: netstat(1): teach netstat to attach to jails (authored by dfr). · Explain Why

This revision was automatically updated to reflect the committed changes.

dfr added a commit: rG182e8ae26d7c: netstat(1): teach netstat to attach to jails.

late to the party, but the man page is missing a .Dd update.

In D41446#944772, @freebsd_igalic.co wrote:

late to the party, but the man page is missing a .Dd update.

Well spotted, thanks - I've pushed an update.

dfr added a commit: rG153a0e6b038c: netstat(1): teach netstat to attach to jails.Sep 2 2023, 11:01 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

netstat/

5 lines

57 lines

79 lines

Diff 126072

usr.bin/netstat/Makefile

Loading...

usr.bin/netstat/main.c

Loading...

usr.bin/netstat/netstat.1

Loading...