vfs: Validate the vop vectors after the default vops applied

[mjg]

huh, that is funny

[mjg]

my bad, the entire point was for validation to happen prior any automagic assignment so filesystems are forced to explicitly state their position on fplookup for given vop vector

what would make more sense is to perform cache_vop_vector_register in the spot you are doing now and call cache_vop_vector_prevalidate or similar prior to the for (name in funcarr) { loop

[dchagin]

In D41337#941279, @mjg wrote:

my bad, the entire point was for validation to happen prior any automagic assignment so filesystems are forced to explicitly state their position on fplookup for given vop vector

I disagree, it’s not an automagic, it is a long lived well known stable code, and, of course, the fix doesn't change the purpose you wanted

what would make more sense is to perform cache_vop_vector_register in the spot you are doing now and call cache_vop_vector_prevalidate or similar prior to the for (name in funcarr) { loop

[mjg]

In D41337#941562, @dchagin wrote:

In D41337#941279, @mjg wrote:

my bad, the entire point was for validation to happen prior any automagic assignment so filesystems are forced to explicitly state their position on fplookup for given vop vector

I disagree, it’s not an automagic, it is a long lived well known stable code, and, of course, the fix doesn't change the purpose you wanted

It does change the purpose because after the possibly intentionally missing fplookup vops get populated, it is impossible to check if the person implementing given vop_vector wanted them to begin with.