Differential D41197

inpcb: use internal flag to mark pcbs that are inserted into lbgroup
ClosedPublic
Actions

Authored by glebius on Jul 26 2023, 3:49 PM.

Details

Reviewers

markj

Group Reviewers

network

Commits

rGa43e7a96b64e: inpcb: use internal flag to mark pcbs that are inserted into lbgroup

Summary

Using INP_REUSEPORT_LB is unsafe, as it is basically a copy of socket's
SO_REUSEPORT_LB flag, which can be cleared by userland after bind().

Reported by: syzbot+e7d2e451f89fb444319b@syzkaller.appspotmail.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52854
Build 49745: arc lint + arc unit

Event Timeline

glebius created this revision.Jul 26 2023, 3:49 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptJul 26 2023, 3:49 PM

glebius requested review of this revision.Jul 26 2023, 3:49 PM

Harbormaster completed remote builds in B52854: Diff 125198.Jul 26 2023, 3:49 PM

glebius added a child revision: D41198: inpcb: do not copy so_options into inp_flags2.Jul 26 2023, 3:49 PM

markj accepted this revision as: markj.Jul 26 2023, 3:53 PM

This revision is now accepted and ready to land.Jul 26 2023, 3:53 PM

Closed by commit rGa43e7a96b64e: inpcb: use internal flag to mark pcbs that are inserted into lbgroup (authored by glebius). · Explain WhyJul 27 2023, 3:52 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGa43e7a96b64e: inpcb: use internal flag to mark pcbs that are inserted into lbgroup.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.h

1 line

in_pcb.c

12 lines

Diff 125198

View Options

sys/netinet/in_pcb.h