struct sysinit: Add SLIST_ENTRY(sysinit) next

[cperciva]

Summary

This will be used to put SYSINITs onto a linked list.

Sponsored by: https://www.patreon.com/cperciva

[jhb]

Any reason for putting it in the middle vs the end? I guess the assumption is that to the extent any performance matters at all you are only going to read func and ident once, but the others you will read multiple times while sorting?

[emaste]

In D41074#935722, @jhb wrote:

Any reason for putting it in the middle vs the end?

I wondered the same thing, even if in practice it makes little difference here.

[cperciva]

In D41074#935722, @jhb wrote:

Any reason for putting it in the middle vs the end? I guess the assumption is that to the extent any performance matters at all you are only going to read func and ident once, but the others you will read multiple times while sorting?

Yeah, I was thinking in terms of having the subsystem/order/next fields in the same cache line. Although on most CPUs the entire structure probably fits in one cache line now, so maybe it didn't accomplish anything.

[jrtc27]

This will need a __FreeBSD_version bump as this is module KBI, right?

[cperciva]

In D41074#945883, @jrtc27 wrote:

This will need a __FreeBSD_version bump as this is module KBI, right?

Good question. I don't know what the policy is, but yeah bad things will happen if we try to load a module with a different struct sysinit layout. I'll bump __FreeBSD_version.