Page MenuHomeFreeBSD

2023Q2 status report for boot performance
ClosedPublic

Authored by cperciva on Jun 25 2023, 7:21 PM.
Tags
None
Referenced Files
F160534947: D40756.diff
Thu, Jun 25, 10:39 AM
Unknown Object (File)
Wed, Jun 24, 4:51 PM
Unknown Object (File)
Mon, Jun 22, 11:09 PM
Unknown Object (File)
Thu, Jun 18, 10:12 PM
Unknown Object (File)
Tue, Jun 9, 12:53 AM
Unknown Object (File)
Thu, May 28, 4:36 AM
Unknown Object (File)
Wed, May 27, 11:23 AM
Unknown Object (File)
Wed, May 27, 9:50 AM
Subscribers

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

grahamperrin added inline comments.
website/content/en/status/report-2023-04-2023-06/boot-performance.adoc
12–15
17–18
20–21

Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?

Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?

Good question. https://docs.freebsd.org/en/articles/freebsd-status-report-process/#_building_the_report is vague on that point. I forgot: are you a docs committer? (And tangentially: did you deliberately make salvadore a blocking reviewer?)

In D40756#927985, @pauamma_gundo.com wrote:

Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?

Good question. https://docs.freebsd.org/en/articles/freebsd-status-report-process/#_building_the_report is vague on that point. I forgot: are you a docs committer? (And tangentially: did you deliberately make salvadore a blocking reviewer?)

I'm a src+ports committer, but during the 13.2 release cycle I was doing a lot of commits to the docs repo and nobody complained. ;-)

I think salvadore was added as a blocking reviewer automatically by the herald system.

Approved by me as well.
I confirm the herald rule added me as blocking reviewer: it is necessary to have status blocking the review. If you have status approval by some other status member it is fine.

You can proceed with the commit autonomously, thanks.

website/content/en/status/report-2023-04-2023-06/boot-performance.adoc
5

As in the other review, please remove the redundant links in the last brackets.

This revision is now accepted and ready to land.Jun 28 2023, 4:04 PM
This revision was automatically updated to reflect the committed changes.