Details
- Reviewers
salvadore carlavilla pauamma_gundo.com - Group Reviewers
status - Commits
- R9:6a97a446cd69: 2023Q2 status report for boot performance
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?
Good question. https://docs.freebsd.org/en/articles/freebsd-status-report-process/#_building_the_report is vague on that point. I forgot: are you a docs committer? (And tangentially: did you deliberately make salvadore a blocking reviewer?)
I'm a src+ports committer, but during the 13.2 release cycle I was doing a lot of commits to the docs repo and nobody complained. ;-)
I think salvadore was added as a blocking reviewer automatically by the herald system.
Approved by me as well.
I confirm the herald rule added me as blocking reviewer: it is necessary to have status blocking the review. If you have status approval by some other status member it is fine.
You can proceed with the commit autonomously, thanks.
website/content/en/status/report-2023-04-2023-06/boot-performance.adoc | ||
---|---|---|
5 | As in the other review, please remove the redundant links in the last brackets. |