vm_radix: eliminate reload in _remove
ClosedPublic
Actions

Authored by dougm on Jun 22 2023, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 21, 7:40 AM

	Unknown Object (File)
	Thu, May 16, 6:15 AM

	Unknown Object (File)
	Apr 21 2024, 6:46 PM

	Unknown Object (File)
	Jan 14 2024, 9:08 AM

	Unknown Object (File)
	Dec 20 2023, 7:22 AM

	Unknown Object (File)
	Nov 28 2023, 8:51 PM

	Unknown Object (File)
	Nov 15 2023, 9:45 AM

	Unknown Object (File)
	Oct 16 2023, 5:22 AM

View All 15 Files

Subscribers

imp

Details

Reviewers

alc

Commits

rGe8efee297c6d: radix_trie: avoid reloading radix node

Summary

In the loop that searches for the last child, load that child once, without loading it again after the search is over. Change a comparison from ">= 1" to "!= 0". The two changes reduce code size by 32 bytes on amd64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 22 2023, 9:42 PM

dougm created this revision.

Drop the broken comparison change. Now, I can only save 16 bytes.

alc added inline comments.Jun 23 2023, 4:21 PM

sys/vm/vm_radix.c
781–784	Wouldn't it now make more sense to assert that tmp is not NULL?

Change asserts to check NULL.

sys/vm/vm_radix.c
781–784	Yes.

alc accepted this revision.Jun 23 2023, 11:03 PM

This revision is now accepted and ready to land.Jun 23 2023, 11:03 PM

Closed by commit rGe8efee297c6d: radix_trie: avoid reloading radix node (authored by dougm). · Explain WhyJun 23 2023, 11:50 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGe8efee297c6d: radix_trie: avoid reloading radix node.

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2023, 11:50 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_pctrie.c

2 lines

vm/

vm_radix.c

11 lines

Diff 123708

View Options

sys/kern/subr_pctrie.c