Page MenuHomeFreeBSD

scsi_all.c: Update to latest asc-num.txt at T10
ClosedPublic

Authored by imp on Jun 22 2023, 5:09 PM.
Tags
None
Referenced Files
F101330005: D40718.diff
Sun, Oct 27, 10:24 PM
Unknown Object (File)
Sun, Oct 13, 8:17 AM
Unknown Object (File)
Sun, Oct 13, 8:16 AM
Unknown Object (File)
Sep 24 2024, 8:59 AM
Unknown Object (File)
Sep 23 2024, 5:10 PM
Unknown Object (File)
Sep 23 2024, 5:09 PM
Unknown Object (File)
Sep 23 2024, 5:09 PM
Unknown Object (File)
Sep 22 2024, 1:05 AM
Subscribers
None

Details

Summary

This updates our table to Sat Mar 25 2023 at 04:30 of the T10
asc-num.txt. I added all the codes that weren't present in the tree,
corrected a couple of the 'alphabet' comments about where the ASC/ASCQ
was defined. I did not, however, make the transition that the
asc-num.txt file made (it deleted W between P and R and added Z after D
so the first few letters shifted a bit). I've not removed the 'W' nor
added the 'Z' at this time. I'm looking for some way to do this
automatically. For all the entries I selected SS_RDEF, except where they
expanded other actions and it was clear those were appropriate.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 22 2023, 5:09 PM

Many of the ASCQs added seem to be not retry-able. It would be good to review them a bit closer and not use SS_RDEF for them.

In D40718#926520, @mav wrote:

Many of the ASCQs added seem to be not retry-able. It would be good to review them a bit closer and not use SS_RDEF for them.

Is there a preferred SS action for these?

SS_FATAL in combination with some error code, like EINVAL, EACCESS, etc.

In D40718#926524, @mav wrote:

SS_FATAL in combination with some error code, like EINVAL, EACCESS, etc.

Thanks... I'll update later today...

best guess at what to do for these codes after reading
sbc4r22.

This revision is now accepted and ready to land.Jun 22 2023, 11:47 PM
This revision was automatically updated to reflect the committed changes.