arm64: Remove a debug print from efi_create_1t1_map()
ClosedPublic
Actions

Authored by markj on Jun 12 2023, 8:11 PM.

Details

Reviewers

andrew
manu

Commits

rG8bea7e28ef1b: arm64: Make a debug print conditional on bootverbose
rG50e1cc94a138: arm64: Make a debug print conditional on bootverbose

Summary

It doesn't seem particularly useful to have it enabled by default, and
it spits several dozen lines into the dmesg on a test system.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 12 2023, 8:11 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 12 2023, 8:11 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

markj requested review of this revision.Jun 12 2023, 8:11 PM

Harbormaster completed remote builds in B52010: Diff 123121.Jun 12 2023, 8:11 PM

markj added a child revision: D40500: arm64: Add a masked get_kernel_reg().Jun 12 2023, 8:11 PM

Any reason to not put it behind bootverbose?

Guard the print behind bootverbose instead.

Harbormaster completed remote builds in B52019: Diff 123158.Jun 13 2023, 12:49 PM

andrew accepted this revision.Jun 13 2023, 12:52 PM

This revision is now accepted and ready to land.Jun 13 2023, 12:52 PM

Closed by commit rG50e1cc94a138: arm64: Make a debug print conditional on bootverbose (authored by markj). · Explain WhyJun 15 2023, 4:42 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG50e1cc94a138: arm64: Make a debug print conditional on bootverbose.

markj added a commit: rG8bea7e28ef1b: arm64: Make a debug print conditional on bootverbose.Jun 23 2023, 1:54 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

efirt_machdep.c

5 lines

Diff 123292

View Options

sys/arm64/arm64/efirt_machdep.c

arm64: Remove a debug print from efi_create_1t1_map()ClosedPublicActions