Page MenuHomeFreeBSD

pf: Fix tests broken by enabling inet-local filtering
ClosedPublic

Authored by dfr on Jun 2 2023, 5:01 PM.
Tags
None
Referenced Files
F133635692: D40393.id122761.diff
Mon, Oct 27, 4:36 AM
Unknown Object (File)
Sun, Oct 26, 1:44 AM
Unknown Object (File)
Sat, Oct 25, 3:29 AM
Unknown Object (File)
Mon, Oct 20, 6:26 AM
Unknown Object (File)
Fri, Oct 17, 2:52 PM
Unknown Object (File)
Sun, Oct 12, 7:05 PM
Unknown Object (File)
Sun, Oct 12, 7:05 PM
Unknown Object (File)
Sun, Oct 12, 7:05 PM

Details

Summary

Three of the pf dummynet tests were using filter rules which matched
both the intended epair interface as well as lo0 which now receives
PFIL_OUT events for messages delivered to the local network stack (if
enabled). This commit changes the rules to match only for the expected
epair interface.

PR: 268717

Test Plan

kyua test -k /usr/tests/Kyuafile sys/netpfil/common/dummynet

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dfr requested review of this revision.Jun 2 2023, 5:01 PM

That's a little unexpected, but given that it'd only happen when the (currently) non-default hook is enabled that fine.
It's also pretty common for users to have a 'set skip on lo' rule, which I assume would prevent this too.

This revision is now accepted and ready to land.Jun 3 2023, 9:55 AM

I actually tried adding a 'skip on lo' rule to these tests but for some reason the dnpipe rules still matched. Possibly i had the rule ordering wrong or needed 'skip quick on lo' instead. In real-world scenarios, I don't think this is likely to be a widespread problem and I still would like to move forward with D40373.