Page MenuHomeFreeBSD
Differential D40353

dumpon: update OpenSSL initialization call
ClosedPublic
Actions

Authored by emaste on May 31 2023, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:36 PM
Unknown Object (File)
Fri, Jan 17, 5:32 PM
Unknown Object (File)
Dec 12 2024, 9:05 PM
Unknown Object (File)
Dec 5 2024, 4:47 PM
Unknown Object (File)
Nov 23 2024, 1:27 AM
Unknown Object (File)
Oct 31 2024, 2:43 PM
Unknown Object (File)
Oct 19 2024, 9:46 AM
Unknown Object (File)
Oct 4 2024, 11:54 PM
View All 58 Files
Subscribers
imp

Details

Reviewers
ngie
khorben_defora.org
def
Commits
rG79d4d7133f07: dumpon: update OpenSSL initialization call
Test Plan
ERR_load_crypto_strings() was deprecated in OpenSSL 1.1.0, and explicit
initialization is generally not reqiured.  In the case of dumpon however
we need to initialize prior to entering capability mode, so replace with
an OPENSSL_init_crypto call.

Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.May 31 2023, 4:32 PM
emaste created this revision.
emaste added reviewers: ngie, khorben_defora.org.

This is a minimal change to avoid calling the deprecated interface; @ngie's D40296 is the full update for dumpon.

emaste updated this revision to Diff 122669.May 31 2023, 5:03 PM
emaste added a reviewer: def.
  • Incorporate D40355 (I mixed up the dumpon and decryptcore changes and thought I had already submitted D40353)
def accepted this revision.May 31 2023, 5:06 PM
This revision is now accepted and ready to land.May 31 2023, 5:06 PM
khorben_defora.org accepted this revision.May 31 2023, 6:08 PM
ngie added a comment.May 31 2023, 10:26 PM

Some of the comments I found elsewhere suggested this is unnecessary with OpenSSL 1.1+. Is this truly needed?

emaste added a comment.Jun 2 2023, 1:19 AM

Is this truly needed?

For applications that enter capability mode I'm opting to err on the side of caution.

emaste mentioned this in D40355: dumpon: check OPENSSL_init_crypto return value.Jun 2 2023, 1:23 AM
Closed by commit rG79d4d7133f07: dumpon: update OpenSSL initialization call (authored by emaste). · Explain WhyJun 2 2023, 1:24 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG79d4d7133f07: dumpon: update OpenSSL initialization call.
Herald added a subscriber: imp. · View Herald TranscriptJun 2 2023, 1:24 AM
emaste mentioned this in D40296: dumpon(8): support OpenSSL 3.Jun 2 2023, 1:41 AM

Revision Contents
Changeset List

PathSize
sbin/
dumpon/
4 lines

Diff 122664

View Options

sbin/dumpon/dumpon.c

Loading...