Page MenuHomeFreeBSD

tests: fix part of the sys/compat32 breakage
Needs ReviewPublic

Authored by kevans on May 23 2023, 1:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 8:29 AM
Unknown Object (File)
Feb 8 2024, 3:52 PM
Unknown Object (File)
Jan 14 2024, 9:35 AM
Unknown Object (File)
Dec 23 2023, 9:45 AM
Unknown Object (File)
Dec 4 2023, 8:03 AM
Unknown Object (File)
Oct 28 2023, 3:21 PM
Unknown Object (File)
Oct 27 2023, 2:24 PM
Unknown Object (File)
Sep 23 2023, 1:48 PM
Subscribers

Details

Reviewers
jrtc27
Summary

The first iteration attempted to flatten out ^/tests/sys/compat32, since
we'll never need to install more than one set of compat32 tests for any
given architecture -- the arch directory ends up being generally
redundant. Unfortunately, the way it was accomplished was incredibly
fragile and relied on an arch subdir providing sys/compat32/Kyuafile.

Fix it by restructuring to operate generally like the libc build; the
^/tests/sys/compat32 Makefile contains the necessary boilerplate to put
a Kyuafile in the right directory regardless of what tests we end up
including, the arch subdirectory provides a Makefile.inc with the bits
needed for building.

The existing compat32 tests remain disabled until a path forward is
solidified for dealing with the build issues.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51626
Build 48517: arc lint + arc unit

Event Timeline

I assume this has been tinderboxed, or, really, test built for aarch64 and one other architecture?

tests/sys/compat32/aarch64/Makefile.inc
2

Reason for moving the comment?

I assume this has been tinderboxed, or, really, test built for aarch64 and one other architecture?

Yes; amd64 in addition, since a proper sanity check on this one requires an installworld + verification of the resulting Kyuafile structure.

tests/sys/compat32/aarch64/Makefile.inc
2

Whoops, just sloppy; had moved it further down to ACFLAGS and split off -target armv7-unknown-freebsd$(OS_REVISION) into -m32 -march=armv7 on a separate line with the comment above it to note that it just won't work with GCC still, but then reverted that manually and managed to botch the comment placement. Will move it back.