Flowtable cleaner problems (3 bugs).

[rrs]

Summary

There are three bugs that I have found in flow-table

1. The cleaner through an optimization that does not work will skip large parts of the hash tables leaving flow entries. This causes you to end up with a full table and basically in-effective use.
2. There is a micro-optimization for IPv4 with the wrong comparison so it always falls to the non-optimized bcmp case.
3. A routing table entry being not "UP" should cause the entry to be invalidated no matter what type of route it is (HOST or NET).

Test Plan

Running it in production at NF :-)

[adrian]

monospaced text

[imp]

You're lame style is making my eyes bleed.

flowtable.c

438

This is a style change.

[rrs]

I disagree with you imp

flowtable.c

438

Actually the style itself is fine.. what I did above matches other places (the routing
code for example) in how one checks for RTF_UP.