Page MenuHomeFreeBSD
Differential D40043

tsort: Add unit tests.
ClosedPublic
Actions

Authored by des on May 10 2023, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 5:27 AM
Unknown Object (File)
May 13 2024, 9:04 AM
Unknown Object (File)
May 10 2024, 12:24 PM
Unknown Object (File)
May 8 2024, 5:44 AM
Unknown Object (File)
May 8 2024, 5:44 AM
Unknown Object (File)
May 8 2024, 5:44 AM
Unknown Object (File)
May 8 2024, 2:10 AM
Unknown Object (File)
May 5 2024, 5:07 PM
View All 24 Files
Subscribers
imp
kevans
markj
ngie

Details

Reviewers
markj
Group Reviewers
Klara
tests
Commits
rG09aee570980b: tsort: Add unit tests.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 10 2023, 1:15 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2023, 1:15 PM
des requested review of this revision.May 10 2023, 1:15 PM
Harbormaster completed remote builds in B51418: Diff 121800.May 10 2023, 1:15 PM
des added a parent revision: D40042: tsort: Replace bcopy() with memcpy()..May 10 2023, 1:15 PM
des added a reviewer: tests.May 10 2023, 1:17 PM
markj accepted this revision as: markj.May 10 2023, 1:27 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/tsort/tests/tsort_test.sh
5

I believe the SPDX identifier is supposed to come first.

This revision is now accepted and ready to land.May 10 2023, 1:27 PM
des marked an inline comment as done.May 10 2023, 1:43 PM
des added inline comments.
usr.bin/tsort/tests/tsort_test.sh
5

Nope https://docs.freebsd.org/en/articles/license-guide/

des marked an inline comment as done.May 10 2023, 1:43 PM
Closed by commit rG09aee570980b: tsort: Add unit tests. (authored by des). · Explain WhyMay 10 2023, 1:46 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG09aee570980b: tsort: Add unit tests..
ngie added a subscriber: ngie.May 10 2023, 10:51 PM
ngie added inline comments.
usr.bin/tsort/tests/Makefile
4

This appears unused.

imp added inline comments.May 10 2023, 11:45 PM
usr.bin/tsort/tests/tsort_test.sh
5

Nope https://docs.freebsd.org/en/articles/license-guide/

Yea. Des is right. We only put it first when it's the summary for the boilerplate

des added inline comments.May 16 2023, 2:44 PM
usr.bin/tsort/tests/Makefile
4

I thought it was required...

kevans added a subscriber: kevans.May 16 2023, 3:22 PM
kevans added inline comments.
usr.bin/tsort/tests/Makefile
4

should only be if you're building non-test PROGS with it

des mentioned this in rGcfa209265a30: tsort: Error out if writing to stdout failed..Jun 14 2023, 1:26 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
tsort/
5 lines
tests/
6 lines
66 lines

Diff 121806

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/tsort/Makefile

Loading...
View Options

usr.bin/tsort/tests/Makefile

Loading...
View Options

usr.bin/tsort/tests/tsort_test.sh

Loading...