git-ghpr: A script to land github pull requests

[imp]

Summary

Sponsored by: Netflix

[markj]

tools/tools/git/git-ghpr

206

I guess "Reviewed by: imp" shouldn't be hard-coded? :)

[kevans]

tools/tools/git/git-ghpr

206

also perhaps some commentary on $HOME/bin/git-fixup-editor

[imp]

tools/tools/git/git-ghpr

206

ah, yea, likely shouldn't be hard coded.
And git-fixup=editor likely should be included here as well.

#!/bin/sh

# Takes 1 arg, the file to edit

fn=$1
dir=$(mktemp -d gfe-XXXXXXXXXXXX)
ofn=$dir/msg

trap "rm -rf $dir" EXIT

sed -e 's/^Reviewed-by:/Reviewed by:/;
        s/^Pull-Request:/Pull Request:/;
        s/^Differential-Revision:/Differential Revision:/' < $fn > $ofn && mv $ofn $fn

is what it does.

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata so that the git commit --trailer stuff can be used in the tooling.

[emaste]

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata

Yes, I'm fine with us updating the commit template, handbook etc. (and adding a note that metadata used to use spaces). I created D40025 for the commit template.