Page MenuHomeFreeBSD

git-ghpr: A script to land github pull requests
Needs ReviewPublic

Authored by imp on May 9 2023, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 3:35 AM
Unknown Object (File)
Thu, Oct 16, 1:32 AM
Unknown Object (File)
Sep 15 2025, 12:36 AM
Unknown Object (File)
Sep 2 2025, 12:20 PM
Unknown Object (File)
Aug 8 2025, 4:44 AM
Unknown Object (File)
Jul 6 2025, 11:40 PM
Unknown Object (File)
Jun 25 2025, 11:14 PM
Unknown Object (File)
Jun 24 2025, 11:49 AM

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51399
Build 48290: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 9 2023, 4:45 PM
imp created this revision.
tools/tools/git/git-ghpr
206

I guess "Reviewed by: imp" shouldn't be hard-coded? :)

tools/tools/git/git-ghpr
206

also perhaps some commentary on $HOME/bin/git-fixup-editor

tools/tools/git/git-ghpr
206

ah, yea, likely shouldn't be hard coded.
And git-fixup=editor likely should be included here as well.

#!/bin/sh

# Takes 1 arg, the file to edit

fn=$1
dir=$(mktemp -d gfe-XXXXXXXXXXXX)
ofn=$dir/msg

trap "rm -rf $dir" EXIT

sed -e 's/^Reviewed-by:/Reviewed by:/;
        s/^Pull-Request:/Pull Request:/;
        s/^Differential-Revision:/Differential Revision:/' < $fn > $ofn && mv $ofn $fn

is what it does.

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata so that the git commit --trailer stuff can be used in the tooling.

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata

Yes, I'm fine with us updating the commit template, handbook etc. (and adding a note that metadata used to use spaces). I created D40025 for the commit template.