bsd.lib.mk: decouple lib*_pic.a from TOOLCHAIN build knob
ClosedPublic
Actions

Authored by emaste on May 1 2023, 8:39 PM.

Details

Reviewers

jrtc27
phk
imp

Commits

rG5f2e84015da7: bsd.lib.mk: decouple lib*_pic.a from TOOLCHAIN build knob

Summary

A user may use a tool chain from a package or just use an existing
tool chain from a previous installation.  There is no reason for this
to disable the installation of lib${LIB}_pic.a.

This also means we don't need to force MK_TOOLCHAIN=yes in lib/libc.
This reverts part of c0f5aeb0329d.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.May 1 2023, 8:39 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptMay 1 2023, 8:39 PM

emaste requested review of this revision.May 1 2023, 8:39 PM

It looks like rG:c0f5aeb0329d could be reverted entirely, but I'm not sure (and Jess is not sure) about the 2nd part off hand.

I'd vote for reverting the second half too provided it works in local testing, but as a separate commit in case some weird setup breaks (/me looks at dirdeps)

This revision is now accepted and ready to land.May 1 2023, 8:43 PM

Closed by commit rG5f2e84015da7: bsd.lib.mk: decouple lib*_pic.a from TOOLCHAIN build knob (authored by emaste). · Explain WhyMay 1 2023, 8:47 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG5f2e84015da7: bsd.lib.mk: decouple lib*_pic.a from TOOLCHAIN build knob.