Page MenuHomeFreeBSD

al_eth: make function definitions consistent with declarations
ClosedPublic

Authored by dim on Apr 22 2023, 12:03 PM.
Tags
None
Referenced Files
F176551495: D39759.diff
Mon, Oct 19, 6:54 PM
Unknown Object (File)
Sat, Oct 17, 9:57 PM
Unknown Object (File)
Thu, Oct 8, 4:16 PM
Unknown Object (File)
Sun, Oct 4, 2:15 AM
Unknown Object (File)
Sun, Oct 4, 2:09 AM
Unknown Object (File)
Thu, Sep 24, 1:33 AM
Unknown Object (File)
Mon, Sep 21, 10:20 PM
Unknown Object (File)
Sep 13 2026, 3:21 AM
Subscribers

Details

Summary

The declarations for al_eth_lm_retimer_ds25_signal_detect() and
al_eth_lm_retimer_ds25_cdr_lock() say that these functions return
'al_bool', but the definitions actually return 'boolean_t'.

Make the definitions match the declarations.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim requested review of this revision.Apr 22 2023, 12:03 PM
emaste added a subscriber: mw.

OK, although we may want to either just use int to match struct al_eth_lm_retimer, or change struct al_eth_lm_retimer to al_bool as well.

This revision is now accepted and ready to land.Apr 24 2023, 1:50 PM

Or just replace al_bool with C99 bool, but that can be done in a future change.