Page MenuHomeFreeBSD

al_eth: make function definitions consistent with declarations
ClosedPublic

Authored by dim on Apr 22 2023, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 16, 1:45 AM
Unknown Object (File)
Thu, Aug 13, 8:52 PM
Unknown Object (File)
Mon, Aug 10, 7:55 AM
Unknown Object (File)
Sun, Aug 9, 4:53 PM
Unknown Object (File)
Wed, Aug 5, 5:48 AM
Unknown Object (File)
Wed, Aug 5, 4:13 AM
Unknown Object (File)
Tue, Jul 28, 1:42 PM
Unknown Object (File)
Sat, Jul 25, 9:57 PM
Subscribers

Details

Summary

The declarations for al_eth_lm_retimer_ds25_signal_detect() and
al_eth_lm_retimer_ds25_cdr_lock() say that these functions return
'al_bool', but the definitions actually return 'boolean_t'.

Make the definitions match the declarations.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim requested review of this revision.Apr 22 2023, 12:03 PM
emaste added a subscriber: mw.

OK, although we may want to either just use int to match struct al_eth_lm_retimer, or change struct al_eth_lm_retimer to al_bool as well.

This revision is now accepted and ready to land.Apr 24 2023, 1:50 PM

Or just replace al_bool with C99 bool, but that can be done in a future change.