Page MenuHomeFreeBSD

arm64: Use FULLKERNEL instead of .ALLSRC in .bin target
ClosedPublic

Authored by stevek on Apr 18 2023, 5:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:56 AM
Unknown Object (File)
Sat, Oct 11, 12:24 AM
Unknown Object (File)
Sat, Oct 11, 12:24 AM
Unknown Object (File)
Sat, Oct 11, 12:24 AM
Unknown Object (File)
Fri, Oct 10, 5:53 PM
Unknown Object (File)
Mon, Sep 29, 11:24 PM
Unknown Object (File)
Jul 26 2025, 9:32 AM
Unknown Object (File)
Jun 24 2025, 4:06 PM

Details

Summary

Using .ALLSRC may get additional arguments that we may not want
and could cause the objcopy to fail.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

IMO this is fine, but also ${.ALLSRC} should only ever be ${FULLKERNEL} so not sure how you'd get this case.

IMO this is fine, but also ${.ALLSRC} should only ever be ${FULLKERNEL} so not sure how you'd get this case.

In downstream build environments, there could be additional dependencies added.

The ${NM} statement should probably also use ${FULLKERNEL}, since that is what we really want to operate on.

In downstream build environments, there could be additional dependencies added.

Ok, fair enough. It could maybe be something like ${.ALLSRC:[1]} instead but I'm fine with it either way

This revision is now accepted and ready to land.Apr 18 2023, 2:19 PM