Page MenuHomeFreeBSD

dtrace: handle NOP instructions in RISC-V
ClosedPublic

Authored by christos on Apr 10 2023, 12:38 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Oct 17, 3:43 AM
Unknown Object (File)
Tue, Oct 14, 7:03 PM
Unknown Object (File)
Tue, Oct 14, 7:03 PM
Unknown Object (File)
Tue, Oct 14, 7:02 PM
Unknown Object (File)
Tue, Oct 14, 7:02 PM
Unknown Object (File)
Tue, Oct 14, 7:56 AM
Unknown Object (File)
Tue, Oct 7, 5:04 PM
Unknown Object (File)
Tue, Sep 23, 4:27 AM
Subscribers

Details

Summary

dtrace_invop_start() was panicking if the provider returned
MATCH_C_NOP (DTRACE_INVOP_NOP).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/cddl/dev/dtrace/riscv/dtrace_subr.c
275

It looks like fbt_invop() returns the original instruction, rather than using the DTRACE_INVOP_* constants. In particular, fbt->fbt_rval is not used anywhere.

We should thus return a nop instruction and match it the way other instructions are matched, rather than having multiple return types.

christos marked an inline comment as done.
christos retitled this revision from dtrace: handle DTRACE_INVOP_NOP in RISC-V to dtrace: handle NOP instructions in RISC-V.
christos edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 10 2023, 3:03 PM