ping: Fix an uninitialized variable

[jlduran_gmail.com]

Summary

The variable oicmp, which holds the original ("quoted packet") ICMP packet in a structured way, did not have a copy of the original ICMP packet obtained from the raw data.
The code was accidentally removed in 20b41303140eee4dfb896558fb83600c5f013d39.
Bring it back.

Reported by: Coverity Scan, cy
CID:
Fixes: 20b41303140eee4dfb896558fb83600c5f013d39
MFC after: 1 week

[cy]

Jumbo commits are discouraged. Can you break this revision into three, please.

One to fix the error.

Another to fix the regression.

A third to fix style(9) + whitespace changes.

[jlduran_gmail.com]

In D39233#893278, @cy wrote:

Jumbo commits are discouraged. Can you break this revision into three, please.

One to fix the error.

Another to fix the regression.

A third to fix style(9) + whitespace changes.

Will do. In that case, I have a commit just to fix style for the entire file (will be submitted after 13.2-RELEASE, as requested).

[cy]

In D39233#893286, @jlduran_gmail.com wrote:

In D39233#893278, @cy wrote:

Jumbo commits are discouraged. Can you break this revision into three, please.

One to fix the error.

Another to fix the regression.

A third to fix style(9) + whitespace changes.

Will do. In that case, I have a commit just to fix style for the entire file (will be submitted after 13.2-RELEASE, as requested).

Typically what I do is create a git branch and do all my commits there. Sometimes I will submit the reviews separately or if it loses context I submit one review, stating that the one review will be commmitted using N commits.

[jlduran_gmail.com]

In D39233#893290, @cy wrote:

In D39233#893286, @jlduran_gmail.com wrote:

In D39233#893278, @cy wrote:

Jumbo commits are discouraged. Can you break this revision into three, please.

One to fix the error.

Another to fix the regression.

A third to fix style(9) + whitespace changes.

Will do. In that case, I have a commit just to fix style for the entire file (will be submitted after 13.2-RELEASE, as requested).

Typically what I do is create a git branch and do all my commits there. Sometimes I will submit the reviews separately or if it loses context I submit one review, stating that the one review will be commmitted using N commits.

Yes, it’s on https://github.com/jlduran/freebsd-src/commits/ping-fix-20b4130. However, I’d like to clean it up a little. Tomorrow will do. Thank you!

[jlduran_gmail.com]

• Move the tests to a separate commit
• Drop style(9) changes

[cy]

LGTM