Page MenuHomeFreeBSD

math.h: Assume gcc, gnu c extensions, and modern compiler
AbandonedPublic

Authored by imp on Mar 15 2023, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 7:47 AM
Unknown Object (File)
Jan 19 2024, 11:58 PM
Unknown Object (File)
Jan 13 2024, 11:37 AM
Unknown Object (File)
Jan 3 2024, 4:57 AM
Unknown Object (File)
Dec 20 2023, 6:01 AM
Unknown Object (File)
Dec 9 2023, 5:55 AM
Unknown Object (File)
Nov 21 2023, 5:04 PM
Unknown Object (File)
Nov 18 2023, 7:08 PM
Subscribers
None

Details

Summary

Sponsored by: Netflix

Test Plan

It's my belief that we can't compile without a gnu compiler.
I don't think that this will break anything in the ports tree, but will do an exp run.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50387
Build 47278: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 15 2023, 5:53 PM
imp created this revision.
imp added reviewers: kib, emaste, vangyzen, jrtc27.
lib/msun/src/math.h
122

For me, the !GNU block clearly shows the intent of the macros, while leaving only the built-in version requires use of gcc docs to figure out the contract. The non-GCC version should be left there, even if as a comment, IMO.

On second thought, go ahead and drop doing this for now.