Page MenuHomeFreeBSD

2023Q1 Valgrind status report
ClosedPublic

Authored by pauamma_gundo.com on Mar 10 2023, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 5:29 AM
Unknown Object (File)
Dec 20 2023, 6:33 AM
Unknown Object (File)
Dec 13 2023, 12:04 AM
Unknown Object (File)
Nov 20 2023, 12:03 PM
Unknown Object (File)
Nov 8 2023, 3:22 PM
Unknown Object (File)
Oct 19 2023, 10:35 AM
Unknown Object (File)
Oct 12 2023, 6:30 AM
Unknown Object (File)
Oct 7 2023, 2:08 PM
Subscribers

Details

Summary

Changes by Pau Amma from author's version:

  • Reformatted for 1 sentence = 1 line.
  • Added some markup for consistency with other reports.

Pull Request: https://github.com/freebsd/freebsd-doc/pull/120

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pauamma_gundo.com created this revision.
salvadore added a subscriber: salvadore.

There is something wrong in those lines about AsciiDoc syntax. See also the rendered result at https://github.com/paulfloyd/freebsd-doc/blob/paulfloyd-valgrind-2023Q1/website/content/en/status/report-2023-01-2023-03/valgrind.adoc .

website/content/en/status/report-2023-01-2023-03/valgrind.adoc
2

This starts correctly with ===, but should not end with ===.

4

This should be Links: + for consistency with other reports. (By the way, I see we have missed the : last quarter too in the valgrind report. I will fix it when I find time.)

5

It needs + at the end of line.

10

We could use package:devel/valgrind-devel[] here.

This revision now requires changes to proceed.Mar 11 2023, 10:41 AM
website/content/en/status/report-2023-01-2023-03/valgrind.adoc
4

Correction: we did not have a valgrind report last quarter. It was 2022Q2.

  • Fix nits salvadore pointed out and a few more I spotted meanwhile.

Should take care of all comments.

website/content/en/status/report-2023-01-2023-03/valgrind.adoc
2

Ooops. (Guess who's been editing Wikipedia lately.)

Looks goot do me, thanks @pauamma.

By the way, as far as status is concerned, I think we do not need to duplicate reviews already started in GitHub. If you would like to have more eyes looking at some particular pull request, feel free to add me as reviewer there directly.

On the other hand, if you need to create Phabricator reviews anyway for other reasons (maybe asking mentor approval?), this is fine too of course.

This revision is now accepted and ready to land.Mar 13 2023, 10:36 PM
This revision was automatically updated to reflect the committed changes.

Committed with two minimal changes:

  • capitalization of Preparing in the title;
  • changed package:devel/valgrind-devel into package:devel/valgrind-devel[].

Thanks @pjfloyd_wanadoo.fr for submitting and @pauamma for reviewing .