multimedia/vlc: Turn off ASLR

[jrm]

Summary

Starting with 13.2, elf processes will have ASLR turned on by default.
However, the vlc binary core dumps with ASLR on, so turn it off until a
proper fix can be found.

This fix is based on a discussion between Ed Maste and Peter
<[e-mail]>.

See also: https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html
PR: 270038

Test Plan

poudriere testport 14 amd64 success; 12.4 and 13.1 i386/amd64 tests running now

[emaste]

LGTM

I see there are a number of other vlc binaries in the pkg-plist (rvlc, nvlc, qvlc, svlc, cvlc), I wonder if they need the same treatment?

[jrm]

In D38994#887639, @emaste wrote:

LGTM

I see there are a number of other vlc binaries in the pkg-plist (rvlc, nvlc, qvlc, svlc, cvlc), I wonder if they need the same treatment?

Those are just

In D38994#887639, @emaste wrote:

LGTM

I see there are a number of other vlc binaries in the pkg-plist (rvlc, nvlc, qvlc, svlc, cvlc), I wonder if they need the same treatment?

The other executables installed (with default options) are wrappers around the vlc binary.

jrm@phe ~ % ls /usr/local/bin/*vlc
/usr/local/bin/cvlc /usr/local/bin/qvlc /usr/local/bin/rvlc /usr/local/bin/vlc
jrm@phe ~ % cat /usr/local/bin/{c,q,r}vlc
#! /bin/sh
exec /usr/local/bin/vlc -I "dummy" "$@"
#! /bin/sh
exec /usr/local/bin/vlc -I "qt" "$@"
#! /bin/sh
exec /usr/local/bin/vlc -I "rc" "$@"

[mjg]

multimedia/vlc/Makefile

34

i think would be good to add a comment why noaslr

[jrm]

Add a comment that refers to the PR.

[jrm]

The other two executables are also wrappers.

% cat /usr/local/bin/{n,s}vlc
#! /bin/sh
exec /usr/local/bin/vlc -I "ncurses" "$@"
#! /bin/sh
exec /usr/local/bin/vlc -I "skins2" "$@"

[mjg]

lgtm, but emaste should to the final stamp

thanks

[emaste]

LGTM

[tcberner]