src.opts.mk: sync FDT and OFED options with kern.opts.mk
ClosedPublic
Actions

Authored by emaste on Mar 7 2023, 6:12 PM.

Details

Reviewers

Commits

rG7661a2abe45c: src.opts.mk: sync FDT and OFED options with kern.opts.mk

Summary

Where options exist in both src.opts.mk and kern.opts.mk they should be
kept in sync.
    
PR:             269994
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Mar 7 2023, 6:12 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptMar 7 2023, 6:12 PM

emaste requested review of this revision.Mar 7 2023, 6:12 PM

emaste added inline comments.Mar 7 2023, 6:15 PM

share/mk/src.opts.mk
286	looks like this gets used in stand/

imp accepted this revision.Mar 7 2023, 6:18 PM

This revision is now accepted and ready to land.Mar 7 2023, 6:18 PM

imp added inline comments.Mar 7 2023, 6:22 PM

share/mk/src.opts.mk
286	Yea, this will break kboot on amd64, but that needs some more thought... and kboot on amd64 doesn't work yet, so it's no biggie

On IRC there's ongoing discussion about kernel OFED support, and that it should probably be enabled on arm64. I think the right path here is to go ahead with this commit, rationalizing the option defaults between userland and kernel, and from there turn options on/off for specific architectures for both kernel and userland.

Closed by commit rG7661a2abe45c: src.opts.mk: sync FDT and OFED options with kern.opts.mk (authored by emaste). · Explain WhyMar 7 2023, 6:41 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG7661a2abe45c: src.opts.mk: sync FDT and OFED options with kern.opts.mk.