stand: fix buffer overflow in getrootmount()
ClosedPublic
Actions

Authored by rew on Feb 22 2023, 6:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 3:29 AM

	Unknown Object (File)
	Wed, Nov 27, 3:27 AM

	Unknown Object (File)
	Wed, Nov 13, 1:46 PM

	Unknown Object (File)
	Nov 5 2024, 3:09 AM

	Unknown Object (File)
	Nov 5 2024, 3:09 AM

	Unknown Object (File)
	Nov 5 2024, 3:09 AM

	Unknown Object (File)
	Nov 5 2024, 2:40 AM

	Unknown Object (File)
	Oct 22 2024, 3:18 AM

Subscribers

Details

Reviewers

manu
imp
kevans
allanjude

Commits

rGc5f019807059: stand: fix buffer overflow in getrootmount()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Feb 22 2023, 6:55 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 22 2023, 6:55 PM

Herald added subscribers: dab, imp. · View Herald Transcript

rew requested review of this revision.Feb 22 2023, 6:55 PM

Harbormaster completed remote builds in B49968: Diff 117782.Feb 22 2023, 6:55 PM

rew added reviewers: imp, kevans.Feb 22 2023, 6:56 PM

Reviewed by: allanjude

Got catch

This revision is now accepted and ready to land.Feb 22 2023, 11:26 PM

This looks good to me... Most of the time, it would be fine and there's no attack surface here since if you can control this you likely can control way more...

Good catch though.

Closed by commit rGc5f019807059: stand: fix buffer overflow in getrootmount() (authored by rew). · Explain WhyFeb 25 2023, 6:43 PM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rGc5f019807059: stand: fix buffer overflow in getrootmount().

Revision Contents
Changeset List

Path

Size

stand/

common/

boot.c

9 lines

Diff 117927

View Options

stand: fix buffer overflow in getrootmount()ClosedPublicActions