Support SMBIOS v3 for 64-bit entry systems

[jmg]

Summary

Under QEMU on arm64 systems, the smbios table is above 4GB
requiring a 64-bit address to access.

[imp]

I think the changes are good. All my comments are purely style and/or portability.
Thanks for doing this...

stand/libsa/smbios.c

37

HAS_SMBV3

would be more in line with what the rest of the loader does.

90

This and below need to be #ifdef or else we get warnings about testing undefined macros

113

I don't like the '4' here either...

121

Don't like the 5 here or the 4 above... Suggest sizeof(SMBIOS3_SIG) - 1.

489

I can't tell from phab, but it looks like these comments don't line up...

498–503

shouldn't these be intended one level?

[jmg]

Ok, will update the patch in a second, also forgot to include the output of the result:

root@freebsd:~ # kenv | grep ^smbios
smbios.bios.reldate="02/06/2015"
smbios.bios.revision="0.0"
smbios.bios.vendor="EFI Development Kit II / OVMF"
smbios.bios.version="0.0.0"
smbios.chassis.maker="QEMU"
smbios.chassis.type="Other"
smbios.chassis.version="virt-7.1"
smbios.memory.enabled="4194304"
smbios.socket.enabled="1"
smbios.socket.populated="1"
smbios.system.maker="QEMU"
smbios.system.product="QEMU Virtual Machine"
smbios.system.version="virt-7.1"
smbios.version="3.0"

[jmg]

address style comments

[jmg]

wrong change made it, this fully addresses comments

[imp]

Looks great! Thanks for such a fast turn around.