Page MenuHomeFreeBSD
Differential D38642

config: error out on malformed env/hint lines
ClosedPublic
Actions

Authored by kevans on Feb 16 2023, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 13, 10:58 AM
Unknown Object (File)
Fri, Jun 12, 5:16 PM
Unknown Object (File)
Tue, May 26, 12:12 PM
Unknown Object (File)
Mon, May 25, 11:41 PM
Unknown Object (File)
Mon, May 25, 10:41 PM
Unknown Object (File)
Sat, May 23, 4:48 AM
Unknown Object (File)
May 10 2026, 8:37 AM
Unknown Object (File)
Apr 6 2026, 7:08 AM
View All Files
Subscribers
None

Details

Reviewers
imp
des
emaste
Commits
rGda8884202940: config: error out on malformed env/hint lines
Summary

We need these to be assignments, error out if they're not.

While we're here, tag errout as __printflike so that the compiler will
sanity check the format string + args.

CID: 1505293

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Feb 16 2023, 5:25 PM
kevans created this revision.
Harbormaster completed remote builds in B49856: Diff 117466.Feb 16 2023, 5:25 PM
kevans added a parent revision: D38641: config: push path() into moveifchanged().Feb 16 2023, 5:25 PM
kevans added a child revision: D38643: config: address a number of Coverity issues.
imp accepted this revision.Feb 16 2023, 5:33 PM

Looks good. I'd be tempted to separate the prinflike thing, but if not that's cool too.

This revision is now accepted and ready to land.Feb 16 2023, 5:33 PM
emaste accepted this revision.Feb 16 2023, 5:52 PM
Closed by commit rGda8884202940: config: error out on malformed env/hint lines (authored by kevans). · Explain WhyFeb 16 2023, 8:38 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGda8884202940: config: error out on malformed env/hint lines.

Revision Contents
Changeset List

PathSize
usr.sbin/
config/
25 lines

Diff 117471

View Options

usr.sbin/config/mkmakefile.cc

Loading...