Differential D38621

ixgbe: Change if condition for RSS and rxcsum
ClosedPublic
Actions

Authored by przemyslawx.lewandowski_intel.com on Feb 16 2023, 11:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 5, 1:07 AM

	Unknown Object (File)
	Sat, Apr 27, 9:03 PM

	Unknown Object (File)
	Sat, Apr 27, 6:04 AM

	Unknown Object (File)
	Apr 8 2024, 4:53 AM

	Unknown Object (File)
	Feb 22 2024, 4:21 AM

	Unknown Object (File)
	Dec 22 2023, 11:27 PM

	Unknown Object (File)
	Dec 22 2023, 11:27 PM

	Unknown Object (File)
	Dec 18 2023, 12:58 AM

View All 20 Files

Subscribers

Details

Reviewers

erj
krzysztof.galazka_intel.com
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rG197106cf41df: ixgbe: Change if condition for RSS and rxcsum
rG95aced446a8c: ixgbe: Change if condition for RSS and rxcsum
rG156424fce98a: ixgbe: Change if condition for RSS and rxcsum

Summary

Fix regarding Bugzilla issue id: 268910. Issue exists on stable/13 and stable/12.
This patch fixes TCP connection hangs for 1 rxq and 1 txq without rxcsum enabled. Documentation for 10G cards and other drivers suggest enabling rxcsum for RSS and disabling otherwise. When PCSD bit is not set then fragment checksum and IP identification are reported in the rx descriptor. When PCSD bit is set then RSS hash value is reported in the rx descriptor. RSS and RX IPP checksum are mutually exclusive.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

przemyslawx.lewandowski_intel.com created this revision.Feb 16 2023, 11:00 AM

Herald added a subscriber: ae. · View Herald TranscriptFeb 16 2023, 11:00 AM

przemyslawx.lewandowski_intel.com requested review of this revision.Feb 16 2023, 11:00 AM

przemyslawx.lewandowski_intel.com added a reviewer: erj.Feb 16 2023, 11:05 AM

przemyslawx.lewandowski_intel.com added a reviewer: krzysztof.galazka_intel.com.Feb 20 2023, 7:30 AM

jeffrey.e.pieper_intel.com accepted this revision.Apr 28 2023, 1:30 PM

This revision is now accepted and ready to land.Apr 28 2023, 1:30 PM

erj accepted this revision.May 24 2023, 11:26 PM

Closed by commit rG156424fce98a: ixgbe: Change if condition for RSS and rxcsum (authored by przemyslawx.lewandowski_intel.com, committed by erj). · Explain WhyMay 24 2023, 11:37 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rG156424fce98a: ixgbe: Change if condition for RSS and rxcsum.

Herald added a subscriber: imp. · View Herald TranscriptMay 24 2023, 11:37 PM

erj added a commit: rG95aced446a8c: ixgbe: Change if condition for RSS and rxcsum.Jun 2 2023, 7:30 PM

erj added a commit: rG197106cf41df: ixgbe: Change if condition for RSS and rxcsum.Jun 2 2023, 7:37 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

2 lines

Diff 122388

sys/dev/ixgbe/if_ix.c

Loading...