Page MenuHomeFreeBSD
Differential D38606

coresight update
Needs ReviewPublic
Actions

Authored by br on Feb 15 2023, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 5:29 AM
Unknown Object (File)
Jul 6 2023, 3:20 AM
Unknown Object (File)
Jun 19 2023, 8:38 PM
Unknown Object (File)
Apr 5 2023, 8:54 PM
Unknown Object (File)
Feb 22 2023, 4:10 PM
Subscribers
andrew
emaste
zlei

Details

Reviewers
manu
Group Reviewers
arm64
Summary
  1. Address DTS format changes of coresight components:
    • "slave-mode" property removed; Input/output ports are now in different DTS tree branches
    • Dynamic funnel has new compat string: "arm,coresight-dynamic-funnel"
  2. Split TMC dev type into TMC_ETR and TMC_ETF. These are hardware config of TMC
  3. setup interrupt handler in TMC if needed (Noop currently)
Test Plan

Tested on ARM Morello

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Feb 15 2023, 2:04 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 15 2023, 2:04 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
br requested review of this revision.Feb 15 2023, 2:04 PM
br edited the summary of this revision. (Show Details)
zlei added a subscriber: zlei.Feb 17 2023, 9:00 AM
andrew added inline comments.Mar 9 2023, 3:09 PM
sys/arm64/coresight/coresight_fdt.c
142

child != NULL

sys/arm64/coresight/coresight_tmc.c
70

Could you create a macro for the index? It will simplify the change if we need to add more resources later.

290

What do we expect the interrupt to do?

Revision Contents
Changeset List

PathSize
sys/
arm64/
coresight/
5 lines
29 lines
4 lines
3 lines
106 lines

Diff 117291

View Options

sys/arm64/coresight/coresight.h

Loading...
View Options

sys/arm64/coresight/coresight_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_funnel_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_tmc.h

Loading...
View Options

sys/arm64/coresight/coresight_tmc.c

Loading...