sys/param.h: Add _WANT_P_OSREL
ClosedPublic
Actions

Authored by kib on Feb 14 2023, 8:54 AM.

Details

Reviewers

dchagin
markj
imp

Commits

rG5942b4b6fde3: sys/param.h: Add _WANT_P_OSREL

Summary

This allows to remove abuse of IN_RTLD from userspace.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Feb 14 2023, 8:54 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 14 2023, 8:54 AM

kib requested review of this revision.Feb 14 2023, 8:54 AM

Missed libc chunks

Im fine

This revision is now accepted and ready to land.Feb 14 2023, 11:07 AM

markj accepted this revision.Feb 14 2023, 2:01 PM

Looks good. I love the cleanup...

I'm kinda thinking we could lose the first 3 of these, though... There must be dozens of other differences that older userlands are already coping with... But that's a separate issue.

In D38585#878016, @imp wrote:

Looks good. I love the cleanup...

I'm kinda thinking we could lose the first 3 of these, though... There must be dozens of other differences that older userlands are already coping with... But that's a separate issue.

Each of such unhandled differences constitutes an ABI bug. I do not see why should we add more bugs by will.

Closed by commit rG5942b4b6fde3: sys/param.h: Add _WANT_P_OSREL (authored by kib). · Explain WhyFeb 15 2023, 12:44 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG5942b4b6fde3: sys/param.h: Add _WANT_P_OSREL.