Page MenuHomeFreeBSD

cxgbe: Allow parse_pkt to internally queue a packet.
ClosedPublic

Authored by jhb on Feb 14 2023, 12:21 AM.
Tags
None
Referenced Files
F83143456: D38577.diff
Mon, May 6, 10:14 PM
Unknown Object (File)
Fri, Apr 26, 8:47 AM
Unknown Object (File)
Fri, Apr 26, 8:47 AM
Unknown Object (File)
Fri, Apr 26, 8:47 AM
Unknown Object (File)
Fri, Apr 26, 1:40 AM
Unknown Object (File)
Fri, Apr 26, 1:15 AM
Unknown Object (File)
Dec 12 2023, 3:50 PM
Unknown Object (File)
Aug 7 2023, 1:45 PM
Subscribers

Details

Summary

If parse_pkt returns EINPROGRESS, return from cxgbe_transmit
without queueing the packet in a txq. Use this to move the call
to ethofld_transmit for packet pacing into parse_pkt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49758
Build 46648: arc lint + arc unit

Event Timeline

np added inline comments.
sys/dev/cxgbe/t4_main.c
3063–3064

Should we get rid of the __predict_false if EINPROGRESS can commonly occur on the fast path for tx?

This revision is now accepted and ready to land.Feb 16 2023, 5:33 PM
sys/dev/cxgbe/t4_main.c
3063–3064

Hmmm, it depends on what we want to optimize for. Plain NIC traffic will still take the rc == 0 case. Also, for the EINPROGRESS case, all the work has already been done in parse_pkt and we are just trying to return after possibly draining the mp_ring, so I think that's still less important to optimize for vs getting down to the fast path for plain TX.