Page MenuHomeFreeBSD

cxgbe: Allow parse_pkt to internally queue a packet.
ClosedPublic

Authored by jhb on Feb 14 2023, 12:21 AM.
Tags
None
Referenced Files
F168136623: D38577.id117495.diff
Wed, Aug 26, 1:19 PM
Unknown Object (File)
Tue, Aug 25, 5:32 PM
Unknown Object (File)
Tue, Aug 25, 10:30 AM
Unknown Object (File)
Tue, Aug 25, 10:00 AM
Unknown Object (File)
Sun, Aug 23, 8:20 PM
Unknown Object (File)
Mon, Aug 17, 8:46 PM
Unknown Object (File)
Mon, Aug 17, 1:46 PM
Unknown Object (File)
Mon, Aug 17, 1:46 PM
Subscribers

Details

Summary

If parse_pkt returns EINPROGRESS, return from cxgbe_transmit
without queueing the packet in a txq. Use this to move the call
to ethofld_transmit for packet pacing into parse_pkt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np added inline comments.
sys/dev/cxgbe/t4_main.c
3063–3070

Should we get rid of the __predict_false if EINPROGRESS can commonly occur on the fast path for tx?

This revision is now accepted and ready to land.Feb 16 2023, 5:33 PM
sys/dev/cxgbe/t4_main.c
3063–3070

Hmmm, it depends on what we want to optimize for. Plain NIC traffic will still take the rc == 0 case. Also, for the EINPROGRESS case, all the work has already been done in parse_pkt and we are just trying to return after possibly draining the mp_ring, so I think that's still less important to optimize for vs getting down to the fast path for plain TX.