Page MenuHomeFreeBSD

cxgbe: Allow parse_pkt to internally queue a packet.
ClosedPublic

Authored by jhb on Feb 14 2023, 12:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 9:31 AM
Unknown Object (File)
Sat, Oct 11, 9:31 AM
Unknown Object (File)
Sat, Oct 11, 9:30 AM
Unknown Object (File)
Sat, Oct 11, 1:53 AM
Unknown Object (File)
Tue, Oct 7, 2:53 AM
Unknown Object (File)
Sat, Oct 4, 6:58 AM
Unknown Object (File)
Aug 14 2025, 11:54 PM
Unknown Object (File)
Aug 6 2025, 10:07 PM
Subscribers

Details

Summary

If parse_pkt returns EINPROGRESS, return from cxgbe_transmit
without queueing the packet in a txq. Use this to move the call
to ethofld_transmit for packet pacing into parse_pkt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np added inline comments.
sys/dev/cxgbe/t4_main.c
3063–3070

Should we get rid of the __predict_false if EINPROGRESS can commonly occur on the fast path for tx?

This revision is now accepted and ready to land.Feb 16 2023, 5:33 PM
sys/dev/cxgbe/t4_main.c
3063–3070

Hmmm, it depends on what we want to optimize for. Plain NIC traffic will still take the rc == 0 case. Also, for the EINPROGRESS case, all the work has already been done in parse_pkt and we are just trying to return after possibly draining the mp_ring, so I think that's still less important to optimize for vs getting down to the fast path for plain TX.