Page MenuHomeFreeBSD

[New Port] sysutils/sndy: sound switcher
ClosedPublic

Authored by fuz on Feb 11 2023, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 2:58 PM
Unknown Object (File)
Mon, Apr 15, 1:49 PM
Unknown Object (File)
Mon, Apr 15, 1:48 PM
Unknown Object (File)
Mon, Apr 15, 1:46 PM
Unknown Object (File)
Mon, Apr 15, 1:38 PM
Unknown Object (File)
Mon, Apr 15, 1:38 PM
Unknown Object (File)
Mon, Apr 15, 1:28 PM
Unknown Object (File)
Mar 2 2024, 7:24 PM

Details

Summary
[New Port] sysutils/sndy: sound switcher

sndy - is an audio switching program that allows you to redirect sound
output to any port of your computer.

The buttons in the program correspond to the init line in your
/dev/sndstat.  Pressing the button toggles the sound output with the
sysctl command hw.snd.default_unit=<X>.  Do not switch audio output
during playback of a single audio file.  The OSS sound system can only
play sound to one device at a time.  Therefore, you need to wait for the
end or completion of the previous sound file before switching.

The scroll bar can be used to change the volume level.  The volume is
changed using the mixer vol <indicator>*10 command.  That is, each digit
from 0 to 10 multiplied by 10 corresponds to a percentage of volume.

The selected pcm is only saved until you reboot.  To save the default
sound output, add hw.snd.default_unit=<number> to the system file
/etc/sysctl.conf

PR:		268570
Test Plan

Tested on i386 amd64 FreeBSD 12.4 13.1. arm64 pending.
See http://fuz.su/~fuz/freebsd/batch1/

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz requested review of this revision.Feb 11 2023, 7:20 PM
grahamperrin added inline comments.
sysutils/sndy/pkg-descr
2
5–17

From the Note under https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkg-descr:

This is not a manual …

A translated user's guide might be better at or around https://github.com/Clockwork6400/sndy#readme.

This revision now requires changes to proceed.Feb 12 2023, 1:25 PM
sysutils/sndy/pkg-descr
5–17

I had instructed the submitter to expand pkg-descr as it did not met the length requirement. I will instruct the submitter to shorten it so it no longer reads like a manual and to translate his README.

Updated pkg-descr with a less verbose version as per guidance
from grahamperrin. Approval from submitter has been obtained
for this change. Submitter has added old pkg-descr to his
project README.

fuz marked 2 inline comments as done.Feb 13 2023, 12:59 AM

Updated the patch to use INSTALL_DATA for the desktop file.

arm64 builds have meanwhile concluded and can be found in the same
place as the other builds.

fuz marked an inline comment as done.Feb 14 2023, 12:02 PM

Is approval from @grahamperrin required to proceed or is mentor approval sufficient?

In D38518#878077, @fuz_fuz.su wrote:

Is approval from @grahamperrin required to proceed or is mentor approval sufficient?

Mentor approval is sufficient. You are free to commit.

diizzy added inline comments.
sysutils/sndy/Makefile
3
19

If you're going to hardcode a version you also need to depend on it

diizzy requested changes to this revision.Feb 14 2023, 6:38 PM
This revision now requires changes to proceed.Feb 14 2023, 6:38 PM

You don't need to wait on submitter to change a line, just upload a new patch with the change.

fuz marked 2 inline comments as done.Feb 14 2023, 7:33 PM
fuz added inline comments.
sysutils/sndy/Makefile
3

I agree. Will fix this in the commit.

19

Please read up on USES=shebangfix and the meaning of ..._OLD_CMD. This indicates the name of the interpreter in the shebang line that is to be replaced with the selected tk interpreter. Therefore, we do not need to depend on it.

sysutils/sndy/Makefile
19

Guess I was a bit unclear about my intentions, does it work with all available versions as it's hardcoded by default?

fuz marked 3 inline comments as done.Feb 14 2023, 7:45 PM
fuz added inline comments.
sysutils/sndy/Makefile
19

Upstream has told me that any tcl version is fine.

fuz marked an inline comment as done.Feb 14 2023, 7:46 PM

Upstream has changed which commit the 0.0.4 tag refers to. Will commit after re-testing.

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 14 2023, 8:24 PM
This revision was automatically updated to reflect the committed changes.