mail/mls: improve and unbreak with -fno-common
ClosedPublic
Actions

Authored by fuz on Feb 11 2023, 7:17 PM.

Details

Reviewers

eduardo
flo

Commits

R11:342a19d2da54: mail/mls: improve and unbreak with -fno-common

Summary

mail/mls: improve and unbreak with -fno-common

 - liberally sprinkle extern all over the place
 - define LICENSE
 - take over maintainership of this unmaintained port
 - ship examples and html files
 - define DOCS and EXAMPLES options
 - pacify portlint and portclippy
 - add a pkg-message as the author intended
 - remove dead MASTER_SITES entry

PR:		259586

Test Plan

Tested on i386 amd64 FreeBSD 12.4 13.1. arm64 pending.
See http://fuz.su/~fuz/freebsd/batch1/

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 49698
Build 46588: arc lint + arc unit

Event Timeline

fuz created this revision.Feb 11 2023, 7:17 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 11 2023, 7:17 PM

fuz requested review of this revision.Feb 11 2023, 7:17 PM

Harbormaster completed remote builds in B49698: Diff 117000.Feb 11 2023, 7:17 PM

Minor comments. Otherwise approved.

mail/mls/Makefile
5	Should probably use https here, too.
mail/mls/files/patch-Makefile
1	I guess the "regenerate patch files" part is also meant by the "pacify portlint and portclippy" line? I'd add it as a separate entry, as is often done.

This revision is now accepted and ready to land.Feb 12 2023, 9:31 PM

fuz added inline comments.Feb 12 2023, 10:19 PM

mail/mls/Makefile
5	Thanks. Will address this in the commit.
mail/mls/files/patch-Makefile
1	No, I generated additional patches with `make makepatch` which as a welcome side effect also regenerated the existing patches.