syncache_socket() does some unnecessary work: before connecting the PCB,
it saves the local address on the stack and restores it before freeing
the PCB in case of an error. However:
- There's no need to restore the old address in the error case.
- The PCB's local address will always be equal to that of the syncache entry anyway.
So just remove this unnecessary code, which appears to date from the
introduction of the syncache 20+ years ago.
No functional change intended.