Page MenuHomeFreeBSD
Differential D38290

cp: Add tests involving sparse files.
ClosedPublic
Actions

Authored by des on Jan 31 2023, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 7:51 PM
Unknown Object (File)
Tue, Nov 26, 7:51 PM
Unknown Object (File)
Tue, Nov 26, 7:51 PM
Unknown Object (File)
Tue, Nov 26, 7:51 PM
Unknown Object (File)
Tue, Nov 26, 6:33 PM
Unknown Object (File)
Tue, Nov 26, 6:33 PM
Unknown Object (File)
Tue, Nov 26, 6:08 PM
Unknown Object (File)
Oct 25 2024, 10:28 AM
View All Files
Subscribers
imp
markj

Details

Reviewers
ngie
markj
rmacklem
Group Reviewers
Klara
Commits
rGd6d22a4530f9: cp: Add tests involving sparse files.
rG822fa7ae1e3e: cp: Add tests involving sparse files.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49348
Build 46238: arc lint + arc unit

Event Timeline

des created this revision.Jan 31 2023, 10:16 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 31 2023, 10:16 AM
des requested review of this revision.Jan 31 2023, 10:16 AM
Harbormaster completed remote builds in B49348: Diff 116097.Jan 31 2023, 10:16 AM
des added reviewers: Klara, rmacklem, ngie.Jan 31 2023, 10:23 AM

As noted in D38191, our cp(1) transparently and unconditionally preserves holes when copying sparse files.

des mentioned this in D38191: cp: Add a -S option which preserves holes in sparse files..Jan 31 2023, 10:24 AM
des updated this revision to Diff 116099.Jan 31 2023, 10:43 AM

Remove test cases that make no sense without the -S option.

Harbormaster completed remote builds in B49350: Diff 116099.Jan 31 2023, 10:44 AM
des updated this revision to Diff 116100.Jan 31 2023, 10:46 AM

Pick nit in sparse_only_hole case.

Harbormaster completed remote builds in B49351: Diff 116100.Jan 31 2023, 10:46 AM
rmacklem resigned from this revision.Jan 31 2023, 10:45 PM

I'm afraid I know nothing about the testing framework,
so I can't help with this one.

Good to see it being done though.

markj accepted this revision as: markj.Feb 1 2023, 7:35 PM
markj added a subscriber: markj.

Seems ok, though these tests might fail if run on unusual filesystems like msdosfs. I think we can address that later if it ever comes up though.

bin/cp/tests/cp_test.sh
328–335

Since these seem to be alphabetically sorted, the sparse tests should come before standalone_Pflag.

This revision is now accepted and ready to land.Feb 1 2023, 7:35 PM
des updated this revision to Diff 116222.Feb 1 2023, 8:03 PM
des marked an inline comment as done.

Order tests lexicographically.

This revision now requires review to proceed.Feb 1 2023, 8:03 PM
Harbormaster completed remote builds in B49425: Diff 116222.Feb 1 2023, 8:03 PM
markj accepted this revision as: markj.Feb 1 2023, 8:47 PM
This revision is now accepted and ready to land.Feb 1 2023, 8:47 PM
Closed by commit rG822fa7ae1e3e: cp: Add tests involving sparse files. (authored by des). · Explain WhyFeb 2 2023, 2:47 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG822fa7ae1e3e: cp: Add tests involving sparse files..
des added a commit: rGd6d22a4530f9: cp: Add tests involving sparse files..Feb 9 2023, 8:41 PM

Revision Contents
Changeset List

PathSize
bin/
cp/
tests/
111 lines

Diff 116097

View Options

bin/cp/tests/cp_test.sh

Loading...