pkgbase: Create a FreeBSD-elftoolchain package
ClosedPublic
Actions

Authored by manu on Jan 27 2023, 3:52 PM.

Details

Reviewers

None

Group Reviewers

pkgbase

Commits

rG1af3908ce612: pkgbase: Create a FreeBSD-elftoolchain package

Summary

It contain all the binaries and libs from the elftoolchain contrib
project except for libelf which is used everywhere.
All of those tools are never used by the average user.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Jan 27 2023, 3:52 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2023, 3:52 PM

manu requested review of this revision.Jan 27 2023, 3:52 PM

Harbormaster completed remote builds in B49263: Diff 115929.Jan 27 2023, 3:52 PM

manu added a parent revision: D38223: pkgbase: Create a FreeBSD-ctf-tools package.Jan 27 2023, 3:52 PM

manu added a child revision: D38225: pkgbase: Create a FreeBSD-netmap package.

manu added a reviewer: pkgbase.Jan 27 2023, 3:53 PM

not sure about /usr/bin/strings, it gets used outside of the context of the toolchain (and is not controlled by WITH_/WITHOUT_TOOLCHAIN).

lib/libdwarf/Makefile
4 ↗	(On Diff #115929)	I think libdwarf doesn't belong in here, especially considering that we'll probably switch to `LLVM_BINUTILS` at which point the elftoolchain package would provide only libdwarf.

usr.bin/elfctl/Makefile
3 ↗	(On Diff #115929)	elfctl is used by some ports. the hope is that it's used before packing, and not as post-install

emaste added inline comments.Jan 27 2023, 4:23 PM

usr.bin/elfctl/Makefile
3 ↗	(On Diff #115929)	elfctl is also not related to elftoolchain

manu added inline comments.Jan 27 2023, 4:30 PM

lib/libdwarf/Makefile
4 ↗	(On Diff #115929)	Ok, I'll keep it in its package.
usr.bin/elfctl/Makefile
3 ↗	(On Diff #115929)	So ?
3 ↗	(On Diff #115929)	Right yes, I just did some grep contrib/elftoolchain and since it uses the contrib dir it showed up and I didn't checked more. I'll remove it.

In D38224#868784, @emaste wrote:

not sure about /usr/bin/strings, it gets used outside of the context of the toolchain (and is not controlled by WITH_/WITHOUT_TOOLCHAIN).

I've put strings because it's contrib code like the other files.
I can drop it if you prefer, does llvm have it's own strings or will we still use this one ?

In D38224#868800, @manu wrote:

In D38224#868784, @emaste wrote:

not sure about /usr/bin/strings, it gets used outside of the context of the toolchain (and is not controlled by WITH_/WITHOUT_TOOLCHAIN).

I've put strings because it's contrib code like the other files.
I can drop it if you prefer, does llvm have it's own strings or will we still use this one ?

Right now WITH_BINUTILS still leaves ELF Tool Chain strings, because it (the binary) is small, and strings doesn't need much ELF/object file knowledge.

usr.bin/elfctl/Makefile
3 ↗	(On Diff #115929)	Right yes, I just did some grep contrib/elftoolchain and since it uses the contrib dir it showed up and I didn't checked more. Oh right, it does use libelftc, so it's not part of ELF Tool Chain but is tied to it. In any case it could be used by a sysadmin / end user, in a way that e.g. ar or objcopy wouldn't be.