IfAPI: Hide the in6m_lookup_locked() implementation.
ClosedPublic
Actions

Authored by jhibbits on Jan 25 2023, 9:20 PM.

Details

Reviewers

glebius
melifaro

Group Reviewers

network

Commits

rG361ac40b0ff6: IfAPI: Hide the in6m_lookup_locked() implementation.

Summary

in6m_lookup_locked() iterates over the ifnet's multiaddrs list. Keep
this implementation detail private, by moving the implementation to the
netstack source from the header.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 25 2023, 9:20 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 25 2023, 9:20 PM

jhibbits requested review of this revision.Jan 25 2023, 9:20 PM

Harbormaster completed remote builds in B49234: Diff 115737.Jan 25 2023, 9:20 PM

melifaro accepted this revision.Jan 25 2023, 9:41 PM

melifaro added inline comments.

sys/netinet6/in6_var.h
783–784	Nit: it’s worth moving the description to the implementation.
793	Is there a point to have it inlined after the change?

This revision is now accepted and ready to land.Jan 25 2023, 9:41 PM

jhibbits marked an inline comment as done.Jan 26 2023, 2:27 PM

jhibbits added inline comments.

sys/netinet6/in6_var.h
783–784	Ack, will do it in commit.
793	Not really. We lose the bulk of the inline performance gain by the branch to the netstack.

glebius accepted this revision.Jan 31 2023, 4:56 PM

glebius added inline comments.

sys/netinet6/in6_mcast.c
353	I'd suggest to add NET_EPOCH_ASSERT() here and remove it from in6m_ifmultiaddr_get_inm(). This would be more correct as the epoch protects the linkage between multiaddrs, not individual address fields.