Page MenuHomeFreeBSD
Differential D38195

Fix cross-build from STABLE or older CURRENT.
ClosedPublic
Actions

Authored by des on Jan 25 2023, 4:50 PM.
Tags
None
Referenced Files
F83038661: D38195.diff
Sun, May 5, 9:37 AM
Unknown Object (File)
Thu, May 2, 6:11 PM
Unknown Object (File)
Thu, May 2, 6:00 PM
Unknown Object (File)
Thu, May 2, 3:43 PM
Unknown Object (File)
Thu, May 2, 2:49 PM
Unknown Object (File)
Thu, May 2, 1:06 PM
Unknown Object (File)
Wed, May 1, 9:49 PM
Unknown Object (File)
Mar 15 2024, 12:32 AM
View All 30 Files
Subscribers
emaste
imp

Details

Reviewers
jrtc27
emaste
Group Reviewers
Klara
Commits
rG7a4a520064cb: Fix cross-build from STABLE or older CURRENT.
Summary

Previously, zic and tzsetup were both listed as install tools and basic
bootstrap tools. Actually, tzsetup is an install tool while zic is a
non-basic bootstrap tool.

Fixes: 783c318fd118
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49227
Build 46117: arc lint + arc unit

Event Timeline

des created this revision.Jan 25 2023, 4:50 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptJan 25 2023, 4:50 PM
des requested review of this revision.Jan 25 2023, 4:50 PM
Harbormaster completed remote builds in B49227: Diff 115724.Jan 25 2023, 4:50 PM
imp added a comment.Jan 25 2023, 4:55 PM

I think this is good. Have you tested on a stable machine?

jrtc27 accepted this revision.Jan 25 2023, 4:56 PM
This revision is now accepted and ready to land.Jan 25 2023, 4:56 PM
emaste accepted this revision.EditedJan 25 2023, 4:58 PM

Fixes: R10:8d5ed6e7174935c6fd7bc25a6e9a58291b75945b also I suspect

jrtc27 added a comment.Jan 25 2023, 4:59 PM
In D38195#867991, @emaste wrote:

Fixes: R10:8d5ed6e7174935c6fd7bc25a6e9a58291b75945b also I suspect

That change looks fine, tzsetup is still in ITOOLS

Closed by commit rG7a4a520064cb: Fix cross-build from STABLE or older CURRENT. (authored by des). · Explain WhyJan 25 2023, 5:04 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG7a4a520064cb: Fix cross-build from STABLE or older CURRENT..
des added a comment.Jan 25 2023, 5:46 PM
In D38195#867987, @imp wrote:

I think this is good. Have you tested on a stable machine?

Yes, I tested on 13.1.

jrtc27 added a reverting change: rGd4fdfd3f9077: Makefile.inc1: Restore adding tzsetup to _basic_bootstrap_tools.Jan 29 2023, 11:55 PM
des added a reverting change: rG93cc70bf9ca7: Bring our tzcode up to date..Jan 31 2023, 9:48 AM

Revision Contents
Changeset List

PathSize
23 lines

Diff 115724

View Options

Makefile.inc1

Loading...