Page MenuHomeFreeBSD

Add the fixed memory type to the pci ecam driver
ClosedPublic

Authored by andrew on Jan 12 2023, 9:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 29, 7:25 PM
Unknown Object (File)
Wed, May 29, 7:25 PM
Unknown Object (File)
Wed, May 29, 7:25 PM
Unknown Object (File)
Wed, May 29, 7:25 PM
Unknown Object (File)
Mar 20 2024, 11:38 AM
Unknown Object (File)
Mar 20 2024, 11:38 AM
Unknown Object (File)
Mar 20 2024, 11:38 AM
Unknown Object (File)
Mar 20 2024, 11:38 AM
Subscribers

Details

Summary

Add ACPI_RESOURCE_TYPE_FIXED_MEMORY32 to the PCI ECAM driver. This is
used on the Microsoft Dev Kit 2023 and reportedly the Lenovo x13s.

Tested by: Robert Clausecker <fuz@fuz.su> (Earlier version)
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This patch tests ok on the Windows 2023 Dev Kit.

sys/dev/pci/pci_host_generic_acpi.c
151

Code could be made less repetitive by moving the standard case out of the switch statement.

This revision is now accepted and ready to land.Jan 12 2023, 10:55 AM
kevans added inline comments.
sys/dev/pci/pci_host_generic_acpi.c
171
  • Use the correct union member to find the resource type
  • Fix a typo
This revision now requires review to proceed.Jan 13 2023, 4:03 PM
andrew added inline comments.
sys/dev/pci/pci_host_generic_acpi.c
151

I switched to using the correct union member rather than rely on it being part of the Address member.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2023, 9:41 AM
This revision was automatically updated to reflect the committed changes.

This patch apparently has not been MFC'ed to 13-stable, preventing the Windows 2023 Dev Kit from booting 13.2-RC6 (in conjunction with D37765 and hw.pac.enable=0). Could this one be MFC'ed?