Page MenuHomeFreeBSD

Always read the VFP regs in the arm64 fill_fpregs
ClosedPublic

Authored by andrew on Jan 9 2023, 8:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 9, 2:03 AM
Unknown Object (File)
Fri, Oct 9, 1:53 AM
Unknown Object (File)
Wed, Sep 30, 4:05 PM
Unknown Object (File)
Tue, Sep 22, 12:26 PM
Unknown Object (File)
Sep 11 2026, 3:54 PM
Unknown Object (File)
Sep 11 2026, 1:15 AM
Unknown Object (File)
Sep 10 2026, 5:43 PM
Unknown Object (File)
Sep 8 2026, 5:34 PM
Subscribers

Details

Summary

The PCB_FP_STARTED is used to indicate that the current VFP context
has been used since either 1. the start of the thread, or 2. exiting
a kernel FP context.

When case 2 was added to the kernel this could cause incorrect results
to be returned when a thread exits the kernel FP context and fill_fpregs
is called before it has restored the VFP state, e.g. by trappin on a
userspace VFP instruction.

In both of the cases the base save area is still valid so reduce the
use of the PCB_FP_STARTED flag check to help decide if we need to
store the current threads VFP state.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable