Page MenuHomeFreeBSD

sys/intr: remove questionable interrupt report
Needs ReviewPublic

Authored by ehem_freebsd_m5p.com on Dec 24 2022, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 8:30 AM
Unknown Object (File)
Dec 21 2023, 11:14 AM
Unknown Object (File)
Dec 11 2023, 4:23 AM
Unknown Object (File)
Dec 10 2023, 8:28 PM
Unknown Object (File)
Sep 6 2023, 3:50 PM
Unknown Object (File)
Jun 24 2023, 8:06 AM
Unknown Object (File)
Jun 24 2023, 4:41 AM
Unknown Object (File)
May 6 2023, 11:12 AM
Subscribers

Details

Reviewers
jhb
Summary

The "???" interrupt doesn't appear useful any more, so remove it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48880
Build 45769: arc lint + arc unit

Event Timeline

History leaves me clueless about this. fd036deac1695 is simply moves it from one spot in the file to another, rG:ecee5704ed500 doesn't mention it at all. If this is simply lint then perhaps time to remove?

The one plausible alternative would be to leave the intrcnt_setname("???", 0); lines in-place to ensure there is always one nominally valid entry, and would then be overwritten when the first entry was allocated. This really looks like an early placeholder for something during bring-up testing, which was supposed to be removed once tested, but then never got removed.

@jhb any thoughts on D37869? As noted this seems to have mysteriously appeared, I've got no idea why this was here and no idea why it should remain.

Ping D37869? This does appear a remnant of something long forgotten which likely has no effects now. Just hoping for a confirmation and getting this done.

Ping D37869. Lack of response really does leave the impression both D37869 and the mystery interrupt entry have been forgotten.