pf: Fix definitions of pf_pfil_*_hooked
ClosedPublic
Actions

Authored by markj on Dec 13 2022, 2:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 8:39 AM

	Unknown Object (File)
	Sat, Jul 4, 5:42 AM

	Unknown Object (File)
	Thu, Jul 2, 8:30 PM

	Unknown Object (File)
	Thu, Jul 2, 7:45 PM

	Unknown Object (File)
	Wed, Jul 1, 7:52 AM

	Unknown Object (File)
	Tue, Jun 23, 2:59 AM

	Unknown Object (File)
	Jun 12 2026, 10:50 AM

	Unknown Object (File)
	Jun 12 2026, 9:48 AM

Subscribers

Details

Reviewers

kp
mjg

Commits

rG57cc96f49e1f: pf: Fix definitions of pf_pfil_*_hooked

Summary

This use of "volatile" in the vnet definitions doesn't have any effect.
VNET_DEFINE_STATE(volatile int, ...) should work, but let's avoid using
"volatile" altogether and convert to atomic_load/atomic_store.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 13 2022, 2:37 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptDec 13 2022, 2:37 PM

markj requested review of this revision.Dec 13 2022, 2:37 PM

Harbormaster completed remote builds in B48702: Diff 114099.Dec 13 2022, 2:37 PM

maybe bool it while at it?

Switch to bool

Harbormaster completed remote builds in B48703: Diff 114100.Dec 13 2022, 2:51 PM

mjg accepted this revision.Dec 13 2022, 2:54 PM

This revision is now accepted and ready to land.Dec 13 2022, 2:54 PM

kp accepted this revision.Dec 14 2022, 4:13 AM

Closed by commit rG57cc96f49e1f: pf: Fix definitions of pf_pfil_*_hooked (authored by markj). · Explain WhyDec 14 2022, 2:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG57cc96f49e1f: pf: Fix definitions of pf_pfil_*_hooked.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

24 lines

Diff 114141

View Options

pf: Fix definitions of pf_pfil_*_hookedClosedPublicActions