Page MenuHomeFreeBSD

bsdconfig(8): add bsddialog(1)
ClosedPublic

Authored by asiciliano on Nov 23 2022, 8:36 PM.
Tags
None
Referenced Files
F103321561: D37480.id115385.diff
Sat, Nov 23, 12:59 PM
Unknown Object (File)
Thu, Oct 31, 7:37 PM
Unknown Object (File)
Sat, Oct 26, 1:36 PM
Unknown Object (File)
Oct 23 2024, 11:26 AM
Unknown Object (File)
Oct 4 2024, 11:27 PM
Unknown Object (File)
Oct 4 2024, 9:54 PM
Unknown Object (File)
Oct 2 2024, 10:37 AM
Unknown Object (File)
Oct 2 2024, 4:21 AM
Subscribers

Details

Summary

Add bsddialog(1) to bsdconfig(8). This can be considered an increment not a replacement, `$DIALOG=dialog' restores dialog(1).

Test Plan

bsddialog 0.4 was released to match the features of bsdconfig.

To test, with a recent CURRENT:
$DIALOG=bsddialog changing /usr/share/bsdconfig/dialog.subr like the review.

otherwise

$ git clone https://gitlab.com/alfix/bsddialog.git
$ cd bsddialog
$ make

$DIALOG=/absolute/path/bsddialog changing /usr/share/bsdconfig/dialog.subr like the review.

Of course it is possible to apply the diff in src/.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 24 2022, 7:48 AM
jrtc27 added inline comments.
usr.sbin/bsdconfig/share/dialog.subr
82–90

Does this not break Xdialog?

2305

Wrong dialog?

usr.sbin/bsdconfig/share/dialog.subr
82–90

Ok. I think you refer to DIALOG_ESC for Xdialog. Otherwise, please let me know how I can reproduce the fault.

I'll fix it under, where -X is parsed/processed and USE_XDIALOG and $DIALOG=Xdialog are set.

2305

OK. I' ll fix.

Thank you for the review, the updated diff should fix.

This revision now requires review to proceed.Jan 21 2023, 12:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2023, 7:31 AM
This revision was automatically updated to reflect the committed changes.