sh: install hard links with same mode as target
ClosedPublic
Actions

Authored by emaste on Nov 23 2022, 3:31 PM.

Details

Reviewers

brd
imp
jilles
bapt

Commits

rGfeb3da25265d: sh: install hard link with same mode as target
rG1dbb9994d4dd: sh: install hard link with same mode as target

Summary

Previously when using NO_ROOT we recorded METALOG entries for the /.profile hard link with a different file mode than the link target, which is not permitted.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Nov 23 2022, 3:31 PM

Herald added a reviewer: jilles. · View Herald TranscriptNov 23 2022, 3:31 PM

I am not sure why we have /.profile and /.cshrc at all, though?

Similar issue with etc/pam.d/ftp, with the same fix.

Split out sh change

bin/csh/Makefile
164 ↗	(On Diff #113440)	Have to change this one, because it gets applied to LINKS= ${BINDIR}/csh ${BINDIR}/tcsh also, resulting in error: entries point to the same inode but have different meta: ./bin/csh,./bin/tcsh in line 11446,11476. off by "mode" A slightly hacky way to do this would be: ${INSTALL_LINK} ${TAG_ARGS} -m ${CONFMODE} ${DESTDIR}/root/.cshrc ${DESTDIR}/.cshrc (bsd.links.mk, bsd.own.mk do not include per-file control over ${LINKMODE})