Page MenuHomeFreeBSD

sh: install hard links with same mode as target
ClosedPublic

Authored by emaste on Nov 23 2022, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 8 2024, 2:02 AM
Unknown Object (File)
Mar 8 2024, 2:01 AM
Unknown Object (File)
Mar 8 2024, 2:01 AM
Unknown Object (File)
Mar 8 2024, 2:01 AM
Unknown Object (File)
Mar 8 2024, 1:49 AM
Unknown Object (File)
Feb 20 2024, 8:37 AM
Unknown Object (File)
Jan 31 2024, 12:11 AM
Unknown Object (File)
Jan 15 2024, 1:52 AM
Subscribers

Details

Summary

Previously when using NO_ROOT we recorded METALOG entries for the /.profile hard link with a different file mode than the link target, which is not permitted.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I am not sure why we have /.profile and /.cshrc at all, though?

Similar issue with etc/pam.d/ftp, with the same fix.

emaste retitled this revision from sh, csh: install hard links with same mode as target to sh: install hard links with same mode as target.
emaste edited the summary of this revision. (Show Details)

Split out sh change

bin/csh/Makefile
164

Have to change this one, because it gets applied to

LINKS=  ${BINDIR}/csh ${BINDIR}/tcsh

also, resulting in

error: entries point to the same inode but have different meta: ./bin/csh,./bin/tcsh in line 11446,11476. off by "mode"

A slightly hacky way to do this would be:

${INSTALL_LINK} ${TAG_ARGS} -m ${CONFMODE} ${DESTDIR}/root/.cshrc ${DESTDIR}/.cshrc

(bsd.links.mk, bsd.own.mk do not include per-file control over ${LINKMODE})

This revision is now accepted and ready to land.Nov 23 2022, 6:56 PM